fix: make minReplicas required

alexec · alexec · commit c000e4152710 · 2021-05-18T17:01:06.000-07:00
diff --git a/api/v1alpha1/scale.go b/api/v1alpha1/scale.go
@@ -1,7 +1,7 @@
 package v1alpha1
 
 type Scale struct {
-	MinReplicas  int32   `json:"minReplicas,omitempty" protobuf:"varint,1,opt,name=minReplicas"`
+	MinReplicas  int32   `json:"minReplicas" protobuf:"varint,1,opt,name=minReplicas"`
 	MaxReplicas  *uint32 `json:"maxReplicas,omitempty" protobuf:"varint,2,opt,name=maxReplicas"` // takes precedence over min
 	ReplicaRatio uint32  `json:"replicaRatio,omitempty" protobuf:"varint,3,opt,name=replicaRatio"`
 }
diff --git a/config/ci.yaml b/config/ci.yaml
@@ -700,6 +700,8 @@ spec:
                         replicaRatio:
                           format: int32
                           type: integer
+                      required:
+                      - minReplicas
                       type: object
                     serviceAccountName:
                       default: pipeline
@@ -2524,6 +2526,8 @@ spec:
                   replicaRatio:
                     format: int32
                     type: integer
+                required:
+                - minReplicas
                 type: object
               serviceAccountName:
                 default: pipeline
diff --git a/config/crd/bases/dataflow.argoproj.io_pipelines.yaml b/config/crd/bases/dataflow.argoproj.io_pipelines.yaml
@@ -1066,6 +1066,8 @@ spec:
                         replicaRatio:
                           format: int32
                           type: integer
+                      required:
+                      - minReplicas
                       type: object
                     serviceAccountName:
                       default: pipeline
diff --git a/config/crd/bases/dataflow.argoproj.io_steps.yaml b/config/crd/bases/dataflow.argoproj.io_steps.yaml
@@ -1023,6 +1023,8 @@ spec:
                   replicaRatio:
                     format: int32
                     type: integer
+                required:
+                - minReplicas
                 type: object
               serviceAccountName:
                 default: pipeline
diff --git a/config/default.yaml b/config/default.yaml
@@ -700,6 +700,8 @@ spec:
                         replicaRatio:
                           format: int32
                           type: integer
+                      required:
+                      - minReplicas
                       type: object
                     serviceAccountName:
                       default: pipeline
@@ -2524,6 +2526,8 @@ spec:
                   replicaRatio:
                     format: int32
                     type: integer
+                required:
+                - minReplicas
                 type: object
               serviceAccountName:
                 default: pipeline
diff --git a/config/dev.yaml b/config/dev.yaml
@@ -700,6 +700,8 @@ spec:
                         replicaRatio:
                           format: int32
                           type: integer
+                      required:
+                      - minReplicas
                       type: object
                     serviceAccountName:
                       default: pipeline
@@ -2524,6 +2526,8 @@ spec:
                   replicaRatio:
                     format: int32
                     type: integer
+                required:
+                - minReplicas
                 type: object
               serviceAccountName:
                 default: pipeline
diff --git a/config/quick-start.yaml b/config/quick-start.yaml
@@ -700,6 +700,8 @@ spec:
                         replicaRatio:
                           format: int32
                           type: integer
+                      required:
+                      - minReplicas
                       type: object
                     serviceAccountName:
                       default: pipeline
@@ -2524,6 +2526,8 @@ spec:
                   replicaRatio:
                     format: int32
                     type: integer
+                required:
+                - minReplicas
                 type: object
               serviceAccountName:
                 default: pipeline

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`package v1alpha1`
`2`	`2`
`3`	`3`	`type Scale struct {`
`4`		- MinReplicas int32 `json:"minReplicas,omitempty" protobuf:"varint,1,opt,name=minReplicas"`
	`4`	+ MinReplicas int32 `json:"minReplicas" protobuf:"varint,1,opt,name=minReplicas"`
`5`	`5`	MaxReplicas *uint32 `json:"maxReplicas,omitempty" protobuf:"varint,2,opt,name=maxReplicas"` // takes precedence over min
`6`	`6`	ReplicaRatio uint32 `json:"replicaRatio,omitempty" protobuf:"varint,3,opt,name=replicaRatio"`
`7`	`7`	`}`