Wrong GIT_ASKPASS value

[jlmounsamy-swiftconnect]

I recently configured git credentials providing in a config management plugin and I noticed something.

By default the GIT_ASKPASS environment variable is set to argocd (as you can see here) which does not wok because the CLI must be named argocd-git-ask-pass to expose the right commands.

I have to override the GIT_ASKPASS variable at the beginning of my script with the right value for it to work.

export GIT_ASKPASS="argocd-git-ask-pass"

Is there something I am missing here or is it an error in util/askpass/server.go?

[chansuke]

I think that problem is in

argo-cd/cmpserver/plugin/plugin.go

Line 252 in 95b191d

env := append(os.Environ(), environ(envEntries)...)

The cmp server needs ARGOCD_BINARY_NAME=argocd-git-ask-pass but instead, it might be getting ARGOCD_BINARY_NAME=argocd-cmp-server from the parent process since os.Environ() is appended first.

Your workaround makes sense to skip the ARGOCD_BINARY_NAME check entirely by directly specifying argocd-git-ask-pass?

[Aamir017]

Hey @chansuke 👋

I think the cleanest way to handle this is to set GIT_ASKPASS and ARGOCD_BINARY_NAME explicitly when building the plugin environment, instead of relying on the parent process:

env := append([]string{
    "GIT_ASKPASS=argocd-git-ask-pass",
    "ARGOCD_BINARY_NAME=argocd-git-ask-pass",
}, os.Environ()...)

This way:

• It always points to the right binary.
• Users don’t have to manually export anything.
• The code stays simple and predictable.

Seems like a straightforward fix without side effects — what do you think?

[nitishfy]

i'd like to take this up.

[nitishfy]

@jlmounsamy-swiftconnect can you share your plugin yaml?

[crenshaw-dev]

I think this might be a dupe of the problem that was fixed by: #24665

I suspect that the problem is that the argocd binary, which is the default GIT_ASKPASS value, isn't present on the CMP sidecar.

So setting GIT_ASKPASS might work for you, but that's only because you've (presumably) ensured there's a copy or a link to the argocd binary called argocd-git-ask-pass. I don't think that's the case in the default manifests.