-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Open
Labels
bugSomething isn't workingSomething isn't workingcomponent:uiUser interfaces bugs and enhancementsUser interfaces bugs and enhancementstriage/pendingThis issue needs further triage to be correctly classifiedThis issue needs further triage to be correctly classified
Description
Checklist:
- I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
- I've included steps to reproduce the bug.
- I've pasted the output of
argocd version.
Describe the bug
In PodView, quickstart action buttons are defined and invoked inline during render. This causes them to re-run every time the PodView re-renders.
- Clicking a group header to open the resource details panel triggers all quickstart calls again.
- Interacting inside the sliding panel also re-triggers quickstarts for every group.
- Closing the panel has the same effect.
argo-cd/ui/src/app/applications/components/application-pod-view/pod-view.tsx
Lines 244 to 246 in ef5b778
| {(podPrefs.sortMode === 'parentResource' || podPrefs.sortMode === 'topLevelResource') && ( | |
| <div key={group.uid}>{group.renderQuickStarts()}</div> | |
| )} |
To Reproduce
- Open an application with multiple pod groups in PodView
- Click on header of any group to open up sliding-panel
- Observe network / navigation behavior (e.g., navigation fired each click) and UI re-renders.
Expected behavior
- Clicking the same group should not trigger duplicate quickstart requests or cause unnecessary re-renders.
- Handler functions and group data should remain stable across renders unless their inputs actually change.
- PodView should only re-render when the underlying data or view preferences change.
you can utilize memoization or useCallback in appliaction-details or
Moving renderQuickStarts out of the inline render flow
Similar issue:
#24285
Screenshots
Quickstarts.mp4
Version
"Version": "v3.2.0+a8cae97",
"BuildDate": "2025-08-14T13:01:55Z",
"GitCommit": "a8cae97da0f3a6065b9594aae7f367fd26e963a6",
"GitTreeState": "clean",
"GoVersion": "go1.25.0",
"Compiler": "gc",
"Platform": "linux/amd64",
"KustomizeVersion": "v5.7.0 2025-06-28T07:00:07Z",
"HelmVersion": "v3.18.4+gd80839c",
"KubectlVersion": "v0.33.1",
"JsonnetVersion": "v0.21.0"
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcomponent:uiUser interfaces bugs and enhancementsUser interfaces bugs and enhancementstriage/pendingThis issue needs further triage to be correctly classifiedThis issue needs further triage to be correctly classified