Skip to content

Use new expr-lang builtins instead of pkg functions #3506

Open
@crenshaw-dev

Description

@crenshaw-dev

Describe the solution you'd like

expr-lang has included int, float, and string functions since 1.14.0. Argo Workflows currently uses expr 1.16.9. Instead of using those functions as implemented in argoproj/pkg, we should use the built-ins.

We should also inline the implementation of jsonpath, since it is trivial and doesn't make sense to externalize to the pkg repo.

This simplifies maintenance, because we don't have to worry about the pkg repo lifecycle as much.

Additional context

More info here: argoproj/argo-cd#22175


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions