Argo Rollouts controller does not abort the canary revision when it already has a full promotion request

[antonioazambuja]

Checklist:

• I've included steps to reproduce the bug.
• I've included the version of argo rollouts.

Describe the bug

The Argo Rollouts controller does not abort the canary revision when it already has a full promotion request.

To Reproduce

1. Deploy a new version on the canary stage with some (or all) pods unavailable:
2. Perform a full promotion on the kubectl-argo-rollouts; (The promotion won't occur because the canary replicaSet won't be healthy)
3. Perform an abort on the kubectl-argo-rollouts;

The steps above will result in the Argo Rollouts controller waiting for the canary stage to be Healthy, and the abort command will be ignored.

Expected behavior

The abort was performed, and the canary stage replicaSet was scaled down.

Screenshots

Version

v1.8.3

Logs

# Paste the logs from the rollout controller

# Logs for the entire controller:
kubectl logs -n argo-rollouts deployment/argo-rollouts

# Logs for a specific rollout:
kubectl logs -n argo-rollouts deployment/argo-rollouts | grep rollout=<ROLLOUTNAME

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.