test:

- add explicit failure test for compressed workflows in removeCompletedTaskSetStatus
- add e2e coverage for WorkflowTaskSet cleanup in completed compressed workflows

Signed-off-by: arpechenin <arpechenin@avito.ru>

Author: arpechenin

test/e2e/executor_plugins_test.go

@@ -46,16 +46,17 @@ func (s *ExecutorPluginsSuite) TestTemplateExecutor() {
 			assert.Contains(t, spec.Volumes[2].Name, "kube-api-access-")
 			assert.Equal(t, "argo-workflows-agent-ca-certificates", spec.Volumes[3].Name)
 
-			require.Len(t, spec.Containers, 2)
+			require.Len(t, spec.Containers, 3)
 			{
-				plug := spec.Containers[0]
+				plug := requireFindContainerByName(t, spec.Containers, "hello-executor-plugin")
+				require.NotNil(t, plug)
 				require.Equal(t, "hello-executor-plugin", plug.Name)
 				require.Len(t, plug.VolumeMounts, 2)
 				assert.Equal(t, "var-run-argo", plug.VolumeMounts[0].Name)
 				assert.Contains(t, plug.VolumeMounts[1].Name, "kube-api-access-")
 			}
 			{
-				agent := spec.Containers[1]
+				agent := requireFindContainerByName(t, spec.Containers, "main")
 				require.Equal(t, "main", agent.Name)
 				require.Len(t, agent.VolumeMounts, 3)
 				assert.Equal(t, "var-run-argo", agent.VolumeMounts[0].Name)
@@ -99,3 +100,15 @@ func (s *ExecutorPluginsSuite) TestCompressedTemplateExecutor_WorkflowTaskSetIsP
 func TestExecutorPluginsSuite(t *testing.T) {
 	suite.Run(t, new(ExecutorPluginsSuite))
 }
+
+func requireFindContainerByName(t *testing.T, containers []apiv1.Container, name string) *apiv1.Container {
+	var result *apiv1.Container
+	for _, container := range containers {
+		if container.Name == name {
+			result = &container
+			break
+		}
+	}
+	require.NotNil(t, result, "could not find container %s", name)
+	return result
+}

test/e2e/manifests/plugins/massive-executor-plugin-configmap.yaml

@@ -64,7 +64,7 @@ data:
                   self.unsupported()
 
       if __name__ == '__main__':
-          httpd = HTTPServer(('', 4355), Plugin)
+          httpd = HTTPServer(('', 4356), Plugin)
           httpd.serve_forever()
     command:
     - python