- add metadata field to executor plugin

- fix comments

Signed-off-by: arpechenin <arpechenin@avito.ru>

Author: arpechenin

.features/pending/15234-argo-workflow-level-executor-plugin-configuration.md

@@ -4,7 +4,7 @@ Component: General
 Issues: 15234
 
 This PR allows configuring the Argo Workflow Executor Plugin for a specific Argo Workflow directly within the Workflow spec.
-This feature enable via `ARGO_WORKFLOW_LEVEL_EXECUTOR_PLUGINS=true` controller env variable
+This feature is enabled via the `ARGO_WORKFLOW_LEVEL_EXECUTOR_PLUGINS=true` controller env variable
 
 
     apiVersion: apps/v1
@@ -30,7 +30,9 @@ Sample executor plugin definition in the Argo workflow spec:
     spec:
       entrypoint: hello-hello-hello
       executorPlugins:
-        - spec:
+        - metadata:
+            name: print-message-plugin
+        spec:
             sidecar:
               container:
                 name: print-message-plugin

Makefile

@@ -664,7 +664,7 @@ ifneq ($(PLUGINS),true)
 	@echo "⚠️  not starting plugins. If you want to test plugins, run 'make start PROFILE=plugins' to start it"
 endif
 ifneq ($(WORKFLOW_LEVEL_PLUGINS),true)
-	@echo "⚠️  not starting worklow-level plugins. If you want to test plugins, run 'make start WORKFLOW_LEVEL_PLUGINS=true' to start it"
+	@echo "⚠️  not starting workflow-level plugins. If you want to test workflow-level plugins, run 'make start WORKFLOW_LEVEL_PLUGINS=true' to start it"
 endif
 	# Check dex, minio, postgres and mysql are in hosts file
 ifeq ($(AUTH_MODE),sso)

api/jsonschema/schema.json

@@ -5,8 +5,9 @@
 Executor Plugins are disabled by default.
 They can be enabled either globally via the Workflow Controller ConfigMap or per workflow.
 Use the corresponding flags to enable them:
-`ARGO_EXECUTOR_PLUGINS=true` - enable plugins globally
-`ARGO_WORKFLOW_LEVEL_EXECUTOR_PLUGINS=true` - enable plugins at the workflow spec level
+`ARGO_EXECUTOR_PLUGINS=true` - enables the use of Executor Plugins defined globally in the controller’s ConfigMap.
+`ARGO_WORKFLOW_LEVEL_EXECUTOR_PLUGINS=true` - allows using Executor Plugin settings specified directly in the workflow spec. These settings take precedence over the global ones.
+These two options are independent of each other: you can enable only the global plugins, only the workflow-level plugins, or both at the same time.
 
 For example, to enable both modes in the Workflow Controller deployment:
 

api/openapi-spec/swagger.json

@@ -889,7 +889,7 @@ WorkflowSpec is the specification of a Workflow.
 |`dnsPolicy`|`string`|Set DNS policy for workflow pods. Defaults to "ClusterFirst". Valid values are 'ClusterFirstWithHostNet', 'ClusterFirst', 'Default' or 'None'. DNS parameters given in DNSConfig will be merged with the policy selected with DNSPolicy. To have DNS options set along with hostNetwork, you have to specify DNS policy explicitly to 'ClusterFirstWithHostNet'.|
 |`entrypoint`|`string`|Entrypoint is a template reference to the starting point of the io.argoproj.workflow.v1alpha1.|
 |`executor`|[`ExecutorConfig`](#executorconfig)|Executor holds configurations of executor containers of the io.argoproj.workflow.v1alpha1.|
-|`executorPlugins`|`Array<`[`ExecutorPlugin`](#executorplugin)`>`|ExecutorPlugins specifies a list of executor plugins at the workflow level. If any plugin is defined here, the corresponding settings from the ConfigMap are ignored.|
+|`executorPlugins`|`Array<`[`ExecutorPlugin`](#executorplugin)`>`|Specifies executor plugins at the workflow level. This field is effective only when the ARGO_WORKFLOW_LEVEL_EXECUTOR_PLUGINS feature gate is enabled. If this field is present (even if empty), executor plugin settings from the controller ConfigMap are ignored. If this field is not set, the controller falls back to the ConfigMap configuration.|
 |`hooks`|[`LifecycleHook`](#lifecyclehook)|Hooks holds the lifecycle hook which is invoked at lifecycle of step, irrespective of the success, failure, or error status of the primary step|
 |`hostAliases`|`Array<`[`HostAlias`](#hostalias)`>`|_No description available_|
 |`hostNetwork`|`boolean`|Host networking requested for this workflow pod. Default to false.|
@@ -1660,11 +1660,12 @@ ExecutorConfig holds configurations of an executor container.
 
 ## ExecutorPlugin
 
-ExecutorPlugin describe workflow level executor plugin settings
+ExecutorPlugin describes workflow-level executor plugin
 
 ### Fields
 | Field Name | Field Type | Description   |
 |:----------:|:----------:|---------------|
+|`metadata`|[`ObjectMeta`](#objectmeta)|_No description available_|
 |`spec`|[`ExecutorPluginSpec`](#executorpluginspec)|_No description available_|
 
 ## LifecycleHook
@@ -3947,7 +3948,7 @@ _No description available_
 | Field Name | Field Type | Description   |
 |:----------:|:----------:|---------------|
 |`automountServiceAccountToken`|`boolean`|AutomountServiceAccount mounts the service account's token. The service account must have the same name as the plugin.|
-|`container`|[`Container`](#container)|_No description available_|
+|`container`|[`Container`](#container)|Container defines the Kubernetes container specification for the sidecar.|
 
 ## Counter