MergeTo and StrategicMergePatch Bug?

[Reklund3]

I am working with programatic merging of workflows and templates.

I am making a call to JoinWorkflowSpec which calls MergeTo.

Inside the MergeTo here function call there is another call to strategicpatch.StrategicMergePatch Version for latest It appears as though the original and patch values that are passed are swapped in relation to the names on strategicpatch.StrategicMergePatch.

In other words, it looks like the original value is passed in as the patch member of strategicpatch.StrategicMergePatch and the patch is pass in as the original.

Is this intended behavior or am I missing something about merging in this way? It definitely changes behavior when updating them to positionally align with the StrategicMergePatch function call. I am experiencing and issue where when I do not provide a default workflow to merge along with the template workflow and the base workflow there is a validation error as the spec.entrypoint from the base template disappears.

It looks like there is an issue referencing another topic but using StrategicMergePatch with a param ordering that makes sense #13297

I can open and issue and contribute a fix if this a bug.