Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): retry transient error on agent pod creation #13655

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fyp711
Copy link
Contributor

@fyp711 fyp711 commented Sep 24, 2024

Fixes #13654

Motivation

When I use the HTTP template, I find it pending all the time.
image
Then I saw that the workflow status was error, and encountered a transient error.
image
error is : failed to create Agent pod. Reason: Operation cannot be fulfilled on resourcequotas "xxxx": the object has been modified; please apply your changes to the latest version and try again

Modifications

When the agent pod creation encounters transient errors, just retry.

@agilgur5 agilgur5 changed the title fix(controller): When creating an agent pod, if it is a transient err… fix(controller): retry transient error on agent pod creation Sep 24, 2024
@agilgur5 agilgur5 added area/controller Controller issues, panics area/agent Argo Agent that runs for HTTP and Plugin templates labels Sep 24, 2024
@fyp711
Copy link
Contributor Author

fyp711 commented Sep 25, 2024

Could anyone help to rerun it ? Thanks!
image

@MasonM
Copy link
Contributor

MasonM commented Sep 25, 2024

@fyp711 That error should hopefully be fixed with #13660. After that's merged, click the "Update branch" button at the bottom of the PR

@fyp711
Copy link
Contributor Author

fyp711 commented Sep 26, 2024

@fyp711 That error should hopefully be fixed with #13660. After that's merged, click the "Update branch" button at the bottom of the PR

Updated thanks.

@fyp711
Copy link
Contributor Author

fyp711 commented Sep 29, 2024

@agilgur5 @Joibel Could you help to review this pr ? If you have free time thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent Argo Agent that runs for HTTP and Plugin templates area/controller Controller issues, panics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating an agent pod, transient error is not retried
3 participants