Cron: don't create minutely workflow on spec error

[tooptoop4]

Pre-requisites

• I have double-checked my configuration
• I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
• I have searched existing issues and could not find a match for this bug
• I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

if we push new cron workflow with some errors, argo could replace it with default one dummy workflow which will run every minute

argo-workflows/ui/src/app/shared/examples.ts

Lines 79 to 87 in ba75efb

	export const exampleCronWorkflow = (namespace: string): CronWorkflow => ({
	metadata: {
	name: randomSillyName(),
	namespace,
	labels
	},
	spec: {
	workflowMetadata: {labels},
	schedule: '* * * * *',

We need option to change this default workflow to some invalid one, to prevent unnecessary dummy jobs run.

this is noted in a comment of the 3.6 blog post but i have also noticed this

Version(s)

3.5.11

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

n/a

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

[Joibel]

Could you provide further information on the exact steps to reproduce this?
I tried:

• Create a bad CronWorkflow using kubectl it does not replace it with the one you linked.
• Create a bad CronWorkflow using argo cli it just reports it as bad, does not submit it and does not replace it
• Create a bad CronWorkflow using the web userinterface it reports it as bad in the user interface and does not submit it and does not replace it