Skip to content

Commit 73abbf8

Browse files
committed
Fix auto const&
1 parent b1f7bd1 commit 73abbf8

28 files changed

+55
-55
lines changed

libevmasm/ConstantOptimiser.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ unsigned ConstantOptimisationMethod::optimiseConstants(
4545
if (item.type() == Push)
4646
pushes[item]++;
4747
std::map<u256, AssemblyItems> pendingReplacements;
48-
for (const auto& it: pushes)
48+
for (auto const& it: pushes)
4949
{
5050
AssemblyItem const& item = it.first;
5151
if (item.data() < 0x100)

libevmasm/ControlFlowGraph.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ void ControlFlowGraph::gatherKnowledge()
292292
}
293293
}
294294
else
295-
for (const auto& tag: tags)
295+
for (auto const& tag: tags)
296296
addWorkQueueItem(item, BlockId(tag), state);
297297
}
298298
else if (block.begin <= pc && pc < block.end)
@@ -327,7 +327,7 @@ BasicBlocks ControlFlowGraph::rebuildCode()
327327
pushes[ref]++;
328328

329329
std::set<BlockId> blocksToAdd;
330-
for (const auto& it: m_blocks)
330+
for (auto const& it: m_blocks)
331331
blocksToAdd.insert(it.first);
332332
std::set<BlockId> blocksAdded;
333333
BasicBlocks blocks;

libsolidity/analysis/ControlFlowBuilder.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ bool ControlFlowBuilder::visit(Return const& _return)
427427
{
428428
appendControlFlow(*_return.expression());
429429
// Returns with return expression are considered to be assignments to the return parameters.
430-
for (const auto& returnParameter: _return.annotation().functionReturnParameters->parameters())
430+
for (auto const& returnParameter: _return.annotation().functionReturnParameters->parameters())
431431
m_currentNode->variableOccurrences.emplace_back(
432432
*returnParameter,
433433
VariableOccurrence::Kind::Assignment,

libsolidity/analysis/DeclarationContainer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ void DeclarationContainer::populateHomonyms(std::back_insert_iterator<Homonyms>
204204
for (DeclarationContainer const* innerContainer: m_innerContainers)
205205
innerContainer->populateHomonyms(_it);
206206

207-
for (const auto& [name, location]: m_homonymCandidates)
207+
for (auto const& [name, location]: m_homonymCandidates)
208208
{
209209
ResolvingSettings settings;
210210
settings.recursive = true;

libsolidity/analysis/NameAndTypeResolver.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ void NameAndTypeResolver::warnHomonymDeclarations() const
250250
DeclarationContainer::Homonyms homonyms;
251251
m_scopes.at(nullptr)->populateHomonyms(back_inserter(homonyms));
252252

253-
for (const auto& [innerLocation, outerDeclarations]: homonyms)
253+
for (auto const& [innerLocation, outerDeclarations]: homonyms)
254254
{
255255
solAssert(innerLocation && !outerDeclarations.empty(), "");
256256

libsolidity/analysis/SyntaxChecker.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ bool SyntaxChecker::visit(UnaryOperation const& _operation)
358358
bool SyntaxChecker::visit(InlineAssembly const& _inlineAssembly)
359359
{
360360
if (_inlineAssembly.flags())
361-
for (const auto& flag: *_inlineAssembly.flags())
361+
for (auto const& flag: *_inlineAssembly.flags())
362362
{
363363
if (*flag == "memory-safe")
364364
{

libsolidity/codegen/ContractCompiler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1349,7 +1349,7 @@ bool ContractCompiler::visit(VariableDeclarationStatement const& _variableDeclar
13491349

13501350
// Local variable slots are reserved when their declaration is visited,
13511351
// and freed in the end of their scope.
1352-
for (const auto& decl: _variableDeclarationStatement.declarations())
1352+
for (auto const& decl: _variableDeclarationStatement.declarations())
13531353
if (decl)
13541354
appendStackVariableInitialisation(*decl, !_variableDeclarationStatement.initialValue());
13551355

libsolidity/codegen/ir/IRGeneratorForStatements.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1168,7 +1168,7 @@ void IRGeneratorForStatements::endVisit(FunctionCall const& _functionCall)
11681168
{
11691169
auto const& errorConstructorCall = dynamic_cast<FunctionCall const&>(*arguments[1]);
11701170
appendCode() << m_utils.requireWithErrorFunction(errorConstructorCall) << "(" <<IRVariable(*arguments[0]).name();
1171-
for (const auto& argument: errorConstructorCall.arguments())
1171+
for (auto const& argument: errorConstructorCall.arguments())
11721172
if (argument->annotation().type->sizeOnStack() > 0)
11731173
appendCode() << ", " << IRVariable(*argument).commaSeparatedList();
11741174
appendCode() << ")\n";
@@ -1215,7 +1215,7 @@ void IRGeneratorForStatements::endVisit(FunctionCall const& _functionCall)
12151215
if (type(*arguments[1]).category() == Type::Category::Tuple)
12161216
{
12171217
auto const& tupleExpression = dynamic_cast<TupleExpression const&>(*arguments[1]);
1218-
for (const auto& component: tupleExpression.components())
1218+
for (auto const& component: tupleExpression.components())
12191219
argumentsOfEncodeFunction.push_back(component);
12201220
}
12211221
else

libsolidity/experimental/analysis/Analysis.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ bool Analysis::check(std::vector<std::shared_ptr<SourceUnit const>> const& _sour
172172

173173
return std::apply([&](auto... _indexTuple) {
174174
return ([&](auto&& _step) {
175-
for (const auto& source: _sourceUnits)
175+
for (auto const& source: _sourceUnits)
176176
if (!_step.analyze(*source))
177177
return false;
178178
return true;

libsolidity/experimental/analysis/TypeInference.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ bool TypeInference::visit(TypeClassDefinition const& _typeClassDefinition)
229229

230230
auto& typeMembersAnnotation = annotation().members[typeConstructor(&_typeClassDefinition)];
231231

232-
for (const auto& subNode: _typeClassDefinition.subNodes())
232+
for (auto const& subNode: _typeClassDefinition.subNodes())
233233
{
234234
subNode->accept(*this);
235235
auto const* functionDefinition = dynamic_cast<FunctionDefinition const*>(subNode.get());
@@ -246,7 +246,7 @@ bool TypeInference::visit(TypeClassDefinition const& _typeClassDefinition)
246246

247247
annotation().typeClassFunctions[typeClass] = std::move(functionTypes);
248248

249-
for (const auto& [functionName, functionType]: functionTypes)
249+
for (auto const& [functionName, functionType]: functionTypes)
250250
{
251251
TypeEnvironmentHelpers const helper{*m_env};
252252
auto typeVars = helper.typeVars(functionType);
@@ -614,7 +614,7 @@ void TypeInference::endVisit(TupleExpression const& _tupleExpression)
614614
case ExpressionContext::Sort:
615615
{
616616
Type const type = m_typeSystem.freshTypeVariable({});
617-
for (const auto& componentType: componentTypes)
617+
for (auto const& componentType: componentTypes)
618618
unify(type, componentType, _tupleExpression.location());
619619
expressionAnnotation.type = type;
620620
break;
@@ -693,7 +693,7 @@ bool TypeInference::visit(TypeClassInstantiation const& _typeClassInstantiation)
693693

694694
std::map<std::string, Type> functionTypes;
695695

696-
for (const auto& subNode: _typeClassInstantiation.subNodes())
696+
for (auto const& subNode: _typeClassInstantiation.subNodes())
697697
{
698698
auto const* functionDefinition = dynamic_cast<FunctionDefinition const*>(subNode.get());
699699
solAssert(functionDefinition);
@@ -710,7 +710,7 @@ bool TypeInference::visit(TypeClassInstantiation const& _typeClassInstantiation)
710710
solAssert(std::holds_alternative<TypeVariable>(m_typeSystem.typeClassVariable(typeClass)));
711711
TypeVariable classVar = std::get<TypeVariable>(m_typeSystem.typeClassVariable(typeClass));
712712

713-
for (const auto& [name, classFunctionType]: classFunctions)
713+
for (auto const& [name, classFunctionType]: classFunctions)
714714
{
715715
if (!functionTypes.count(name))
716716
{
@@ -860,7 +860,7 @@ void TypeInference::endVisit(FunctionCall const& _functionCall)
860860

861861
TypeSystemHelpers const helper{m_typeSystem};
862862
std::vector<Type> argTypes;
863-
for (const auto& arg: _functionCall.arguments())
863+
for (auto const& arg: _functionCall.arguments())
864864
{
865865
switch (m_expressionContext)
866866
{
@@ -1125,7 +1125,7 @@ void TypeInference::unify(Type _a, Type _b, langutil::SourceLocation _location)
11251125
if (helper.isTypeConstant(sortMismatch->type))
11261126
{
11271127
TypeConstructor const constructor = std::get<0>(helper.destTypeConstant(sortMismatch->type));
1128-
for (const auto& typeClass: sortMismatch->sort.classes)
1128+
for (auto const& typeClass: sortMismatch->sort.classes)
11291129
{
11301130
if (auto const* instantiation = util::valueOrDefault(typeClassInstantiations(m_analysis, typeClass), constructor, nullptr))
11311131
{

0 commit comments

Comments
 (0)