cast to unsigned char before std::isprint in jsonParseStrict

metsw24-max · metsw24-max · commit 9faf0a870120 · 2026-06-09T10:10:52.000+05:30
diff --git a/libsolutil/JSON.cpp b/libsolutil/JSON.cpp
@@ -157,7 +157,7 @@ bool jsonParseStrict(std::string const& _input, Json& _json, std::string* _errs
 		{
 			std::stringstream escaped;
 			for (char c: removeNlohmannInternalErrorIdentifier(e.what()))
-				if (std::isprint(c))
+				if (std::isprint(static_cast<unsigned char>(c)))
 					escaped << c;
 				else
 					escaped << "\\x" + toHex(static_cast<uint8_t>(c));

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ bool jsonParseStrict(std::string const& _input, Json& _json, std::string* _errs`
`157`	`157`	`{`
`158`	`158`	`std::stringstream escaped;`
`159`	`159`	`for (char c: removeNlohmannInternalErrorIdentifier(e.what()))`
`160`		`- if (std::isprint(c))`
	`160`	`+ if (std::isprint(static_cast<unsigned char>(c)))`
`161`	`161`	`escaped << c;`
`162`	`162`	`else`
`163`	`163`	`escaped << "\\x" + toHex(static_cast<uint8_t>(c));`