test: Avoid nested designated initializers that crash MSVC

Author: djolertrk

test/liblangutil/DebugData.cpp

@@ -38,30 +38,30 @@ BOOST_AUTO_TEST_CASE(carries_semantic_debug_data)
 	ethdebugPointer.name = "value";
 	ethdebugPointer.slot = "pointer:value";
 
-	auto semanticDebugData = std::make_shared<SemanticDebugData const>(SemanticDebugData{
-		.lexicalScopeID = 17,
-		.variableDefinitions = {{
-			.name = "value",
-			.declarationAstID = 23,
-			.declarationLocation = SourceLocation{1, 6, std::make_shared<std::string>("input.sol")},
-			.typeID = "type:uint256",
-			.ethdebugType = SemanticDebugType{
-				.typeClass = SemanticDebugType::Class::Elementary,
-				.kind = SemanticDebugType::Kind::Uint,
-				.bits = 256,
-				.places = std::nullopt,
-				.bytes = std::nullopt,
-				.dataLocation = std::nullopt,
-				.payable = std::nullopt,
-				.dynamic = std::nullopt
-			},
-			.location = SemanticDebugVariableLocation{
-				.kind = SemanticDebugVariableLocation::Kind::Stack,
-				.pointerID = "pointer:value"
-			},
-			.ethdebugPointer = ethdebugPointer
-		}}
-	});
+	// NOTE: Built imperatively instead of with nested designated initializers,
+	// which crash MSVC with an internal compiler error.
+	SemanticDebugType ethdebugType;
+	ethdebugType.typeClass = SemanticDebugType::Class::Elementary;
+	ethdebugType.kind = SemanticDebugType::Kind::Uint;
+	ethdebugType.bits = 256;
+
+	SemanticDebugVariableLocation location;
+	location.kind = SemanticDebugVariableLocation::Kind::Stack;
+	location.pointerID = "pointer:value";
+
+	SemanticDebugVariable variable;
+	variable.name = "value";
+	variable.declarationAstID = 23;
+	variable.declarationLocation = SourceLocation{1, 6, std::make_shared<std::string>("input.sol")};
+	variable.typeID = "type:uint256";
+	variable.ethdebugType = ethdebugType;
+	variable.location = location;
+	variable.ethdebugPointer = ethdebugPointer;
+
+	SemanticDebugData data;
+	data.lexicalScopeID = 17;
+	data.variableDefinitions.emplace_back(std::move(variable));
+	auto semanticDebugData = std::make_shared<SemanticDebugData const>(std::move(data));
 
 	auto debugData = DebugData::create(
 		SourceLocation{},
@@ -98,9 +98,9 @@ BOOST_AUTO_TEST_CASE(carries_semantic_debug_data)
 
 BOOST_AUTO_TEST_CASE(semantic_debug_data_table_uses_ast_id)
 {
-	auto semanticDebugData = std::make_shared<SemanticDebugData const>(SemanticDebugData{
-		.lexicalScopeID = 17
-	});
+	SemanticDebugData data;
+	data.lexicalScopeID = 17;
+	auto semanticDebugData = std::make_shared<SemanticDebugData const>(std::move(data));
 
 	SemanticDebugDataTable table;
 	BOOST_CHECK(table.empty());

test/libyul/DebugData.cpp

@@ -78,11 +78,12 @@ SemanticDebugDataTable stackVariableTable(int64_t _astID, std::string _name, std
 	};
 	variable.ethdebugPointer = stackPointer(std::move(_slot));
 
+	SemanticDebugData data;
+	data.lexicalScopeID = _astID;
+	data.variableDefinitions.emplace_back(std::move(variable));
+
 	SemanticDebugDataTable table;
-	table.set(_astID, std::make_shared<SemanticDebugData const>(SemanticDebugData{
-		.lexicalScopeID = _astID,
-		.variableDefinitions = {std::move(variable)}
-	}));
+	table.set(_astID, std::make_shared<SemanticDebugData const>(std::move(data)));
 	return table;
 }
 
@@ -145,9 +146,9 @@ BOOST_AUTO_TEST_CASE(semantic_debug_data_survives_reparse_by_ast_id)
 	BOOST_REQUIRE(funDef->debugData->astID);
 	BOOST_REQUIRE_EQUAL(*funDef->debugData->astID, 23);
 
-	auto semanticDebugData = std::make_shared<SemanticDebugData const>(SemanticDebugData{
-		.lexicalScopeID = 17
-	});
+	SemanticDebugData data;
+	data.lexicalScopeID = 17;
+	auto semanticDebugData = std::make_shared<SemanticDebugData const>(std::move(data));
 	funDef->debugData = DebugData::create(
 		funDef->debugData->nativeLocation,
 		funDef->debugData->originLocation,
@@ -202,10 +203,10 @@ BOOST_AUTO_TEST_CASE(reparse_marks_missing_stack_locations_optimized_out)
 	};
 	variable.ethdebugPointer = stackPointer("missing_slot");
 
-	auto semanticDebugData = std::make_shared<SemanticDebugData const>(SemanticDebugData{
-		.lexicalScopeID = 17,
-		.variableDefinitions = {std::move(variable)}
-	});
+	SemanticDebugData data;
+	data.lexicalScopeID = 17;
+	data.variableDefinitions.emplace_back(std::move(variable));
+	auto semanticDebugData = std::make_shared<SemanticDebugData const>(std::move(data));
 	funDef->debugData = DebugData::create(
 		funDef->debugData->nativeLocation,
 		funDef->debugData->originLocation,