fix(docs): contradictory description of send in Subcurrency Example#16735
Merged
cameel merged 1 commit intoJun 8, 2026
Merged
Conversation
czepluch
approved these changes
May 25, 2026
czepluch
left a comment
czepluch
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this. Good catch.
The paragraph described an `if` condition evaluating to true on insufficient balance, which contradicts the `require(amount <= balance, ...)` shown in the code. The wording was left over from an earlier version of the example that used an explicit `if`/`revert` form. Rewrite to describe the `require` condition directly: it evaluates to false when the sender has insufficient funds, triggering the revert with the `InsufficientBalance` error. Signed-off-by: Thijmen Maus <hi@thijmau.dev>
cameel
force-pushed
the
docs/fix-subcurrency-evaluation-logic
branch
from
68a2c34 to
420cac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
AI Disclosure
Claude (Anthropic) was used for formatting the original issue body of #16730 and for tidying up the commit message. All technical content was verified by me.
Closes #16730