cast to unsigned char before std::isprint in jsonParseStrict#16785
Open
metsw24-max wants to merge 1 commit into
Open
cast to unsigned char before std::isprint in jsonParseStrict#16785metsw24-max wants to merge 1 commit into
metsw24-max wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed char passed to std::isprint in jsonParseStrict
The formatter walks the nlohmann error string a
charat a time and hands each value tostd::isprint. Because the message echoes the offending input bytes, anything from 0x80 upward arrives as a negativeinton signed-char builds, which falls outside the range the<cctype>overload is defined for. Casting tounsigned charfirst keeps the argument valid and lines up with theisPrinthelper already used elsewhere in the tree.The path is reachable from untrusted input via the standard-JSON interface and the LSP transport, so it seemed worth tidying even though most libc builds happen to tolerate it.