Test: Enable SSA-CFG by default for all semantic tests#16786
Merged
Conversation
We can now run SSA-CFG codegen for all semantic tests and we should be doing that. The idea is to enable SSA-CFG by default (runs unless explicitly disabled). Since this requires experimental flag, we also make experimental true by default if SSA-CFG is enabled.
nikola-matic
reviewed
Jun 9, 2026
nikola-matic
previously approved these changes
Jun 9, 2026
Contributor
|
@blishko since EDR external test if failing due to pnpm versioning, you might as well remove the ssa cfg and experimental options in the |
Previously we had to explicitly enable SSA-CFG pipeline, and with it, the experimental option. With the previous commit, SSA-CFG is enabled by default and that enables also the experimental flag. So we don't have to explicitly specify these options anymore for external contracts in semantic tests.
Contributor
Author
I have removed these options from |
clonker
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can now run SSA-CFG codegen for all semantic tests and we should be doing that.
The idea is to enable SSA-CFG by default (runs unless explicitly disabled). Since this requires experimental flag, we also make experimental true by default if SSA-CFG is enabled.