Skip to content

Commit 4592c6c

Browse files
committed
Revert "bytedance: vdpa: Add deletion timeout support"
This reverts commit 346ba4e. Signed-off-by: Andrea Righi <[email protected]>
1 parent 94b7a96 commit 4592c6c

File tree

6 files changed

+6
-16
lines changed

6 files changed

+6
-16
lines changed

drivers/vdpa/vdpa.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ static int vdpa_match_remove(struct device *dev, void *data)
353353
struct vdpa_mgmt_dev *mdev = vdev->mdev;
354354

355355
if (mdev == data)
356-
mdev->ops->dev_del(mdev, vdev, -1);
356+
mdev->ops->dev_del(mdev, vdev);
357357
return 0;
358358
}
359359

@@ -708,15 +708,11 @@ static int vdpa_nl_cmd_dev_del_set_doit(struct sk_buff *skb, struct genl_info *i
708708
struct device *dev;
709709
const char *name;
710710
int err = 0;
711-
int timeout = -1;
712711

713712
if (!info->attrs[VDPA_ATTR_DEV_NAME])
714713
return -EINVAL;
715714
name = nla_data(info->attrs[VDPA_ATTR_DEV_NAME]);
716715

717-
if (info->attrs[VDPA_ATTR_DEV_DEL_TIMEOUT])
718-
timeout = nla_get_u16(info->attrs[VDPA_ATTR_DEV_DEL_TIMEOUT]);
719-
720716
down_write(&vdpa_dev_lock);
721717
dev = bus_find_device(&vdpa_bus, NULL, name, vdpa_name_match);
722718
if (!dev) {
@@ -731,7 +727,7 @@ static int vdpa_nl_cmd_dev_del_set_doit(struct sk_buff *skb, struct genl_info *i
731727
goto mdev_err;
732728
}
733729
mdev = vdev->mdev;
734-
mdev->ops->dev_del(mdev, vdev, timeout);
730+
mdev->ops->dev_del(mdev, vdev);
735731
mdev_err:
736732
put_device(dev);
737733
dev_err:
@@ -1256,7 +1252,6 @@ static const struct nla_policy vdpa_nl_policy[VDPA_ATTR_MAX + 1] = {
12561252
[VDPA_ATTR_DEV_NET_CFG_MTU] = NLA_POLICY_MIN(NLA_U16, 68),
12571253
[VDPA_ATTR_DEV_QUEUE_INDEX] = { .type = NLA_U32 },
12581254
[VDPA_ATTR_DEV_FEATURES] = { .type = NLA_U64 },
1259-
[VDPA_ATTR_DEV_DEL_TIMEOUT] = { .type = NLA_U16 },
12601255
};
12611256

12621257
static const struct genl_ops vdpa_nl_ops[] = {

drivers/vdpa/vdpa_sim/vdpa_sim_blk.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ static int vdpasim_blk_dev_add(struct vdpa_mgmt_dev *mdev, const char *name,
457457
}
458458

459459
static void vdpasim_blk_dev_del(struct vdpa_mgmt_dev *mdev,
460-
struct vdpa_device *dev, int timeout)
460+
struct vdpa_device *dev)
461461
{
462462
struct vdpasim *simdev = container_of(dev, struct vdpasim, vdpa);
463463

drivers/vdpa/vdpa_sim/vdpa_sim_net.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,7 @@ static int vdpasim_net_dev_add(struct vdpa_mgmt_dev *mdev, const char *name,
501501
}
502502

503503
static void vdpasim_net_dev_del(struct vdpa_mgmt_dev *mdev,
504-
struct vdpa_device *dev, int timeout)
504+
struct vdpa_device *dev)
505505
{
506506
struct vdpasim *simdev = container_of(dev, struct vdpasim, vdpa);
507507

drivers/vdpa/vdpa_user/vduse_dev.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2020,8 +2020,7 @@ static int vdpa_dev_add(struct vdpa_mgmt_dev *mdev, const char *name,
20202020
return 0;
20212021
}
20222022

2023-
static void vdpa_dev_del(struct vdpa_mgmt_dev *mdev,
2024-
struct vdpa_device *dev, int timeout)
2023+
static void vdpa_dev_del(struct vdpa_mgmt_dev *mdev, struct vdpa_device *dev)
20252024
{
20262025
_vdpa_unregister_device(dev);
20272026
}

include/linux/vdpa.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -537,15 +537,13 @@ void vdpa_set_status(struct vdpa_device *vdev, u8 status);
537537
* @dev_del: Remove a vdpa device using unregister
538538
* @mdev: parent device to use for device removal
539539
* @dev: vdpa device to remove
540-
* @timetou: delete timeout
541540
* Driver need to remove the specified device by calling
542541
* _vdpa_unregister_device().
543542
*/
544543
struct vdpa_mgmtdev_ops {
545544
int (*dev_add)(struct vdpa_mgmt_dev *mdev, const char *name,
546545
const struct vdpa_dev_set_config *config);
547-
void (*dev_del)(struct vdpa_mgmt_dev *mdev,
548-
struct vdpa_device *dev, int timeout);
546+
void (*dev_del)(struct vdpa_mgmt_dev *mdev, struct vdpa_device *dev);
549547
};
550548

551549
/**

include/uapi/linux/vdpa.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,6 @@ enum vdpa_attr {
5656
/* virtio features that are provisioned to the vDPA device */
5757
VDPA_ATTR_DEV_FEATURES, /* u64 */
5858

59-
VDPA_ATTR_DEV_DEL_TIMEOUT = 128, /* u16 */
60-
6159
/* new attributes must be added above here */
6260
VDPA_ATTR_MAX,
6361
};

0 commit comments

Comments
 (0)