Skip to content

Commit 2132bf8

Browse files
Copilotarii
andcommitted
Clarify token generation timing in configure.sh messaging
- Update summary to say "automatic at deployment" instead of "will auto-generate" - Add note after file creation explaining tokens are generated at deployment - Clarify that empty token fields are intentional for security - Make it clear when manual tokens expire (1 hour) - Helps users understand why .env.runner has empty token fields Co-authored-by: arii <342438+arii@users.noreply.github.com>
1 parent 510aac3 commit 2132bf8

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

deploy/runner/configure.sh

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,11 +215,11 @@ echo ""
215215
echo "Configuration summary:"
216216
echo " Repository: $REPO_URL"
217217
if [ -n "$RUNNER_TOKEN" ]; then
218-
echo " Runner token: [provided manually]"
218+
echo " Runner token: [provided manually - will expire in 1 hour]"
219219
elif [ -n "$GITHUB_PAT" ]; then
220-
echo " GitHub PAT: [provided - will auto-generate tokens]"
220+
echo " GitHub PAT: [provided - tokens will be generated at deployment]"
221221
else
222-
echo " Token: [will auto-generate using GitHub CLI]"
222+
echo " Token generation: GitHub CLI (automatic at deployment)"
223223
fi
224224
if [ -n "$RUNNER_MEMORY_LIMIT" ]; then
225225
echo " Memory limit: $RUNNER_MEMORY_LIMIT"
@@ -274,6 +274,14 @@ echo ""
274274
echo "File: $(pwd)/.env.runner"
275275
echo "Permissions: 600 (read/write for owner only)"
276276
echo ""
277+
278+
# Add clarification about token generation timing
279+
if [ -z "$RUNNER_TOKEN" ] && [ -z "$GITHUB_PAT" ]; then
280+
echo -e "${BLUE}Note: Runner tokens will be auto-generated when you run deploy-runner.sh${NC}"
281+
echo " (Tokens are not stored in the config file for security)"
282+
echo ""
283+
fi
284+
277285
echo "Next steps:"
278286
echo " 1. Review the configuration: cat .env.runner"
279287
echo " 2. Deploy the runner: ./deploy-runner.sh"

0 commit comments

Comments
 (0)