feat(medium): Refactor page readiness logic and consolidate CI scripts (#9069)

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: arii <342438+arii@users.noreply.github.com>

Author: arii

.github/actions/setup-env/action.yml

@@ -53,28 +53,18 @@ runs:
     - name: Install GitHub CLI
       shell: bash
       run: |
-        mkdir -p $HOME/.local/bin
-        # Detect OS and Architecture
-        OS="$(uname -s | tr '[:upper:]' '[:lower:]')"
-        ARCH="$(uname -m)"
-        if [ "$ARCH" = "x86_64" ]; then
-          ARCH="amd64"
-        elif [ "$ARCH" = "aarch64" ] || [ "$ARCH" = "arm64" ]; then
-          ARCH="arm64"
+        if ! command -v gh &> /dev/null; then
+          echo "GitHub CLI not found, installing..."
+          type -p curl >/dev/null || (sudo apt update && sudo apt install curl -y)
+          curl -fsSL https://cli.github.com/packages/githubcli-archive-keyring.gpg | sudo dd of=/usr/share/keyrings/githubcli-archive-keyring.gpg \
+          && sudo chmod go+r /usr/share/keyrings/githubcli-archive-keyring.gpg \
+          && echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | sudo tee /etc/apt/sources.list.d/github-cli.list > /dev/null \
+          && sudo apt update \
+          && sudo apt install gh -y
+        else
+          echo "GitHub CLI already installed: $(gh --version)"
         fi
 
-        GH_VERSION=2.63.0
-        URL="https://github.com/cli/cli/releases/download/v${GH_VERSION}/gh_${GH_VERSION}_${OS}_${ARCH}.tar.gz"
-
-        echo "Downloading GitHub CLI from $URL"
-        curl -L "$URL" -o gh.tar.gz
-        tar xvf gh.tar.gz
-
-        # Move binary to local bin
-        mv "gh_${GH_VERSION}_${OS}_${ARCH}/bin/gh" "$HOME/.local/bin/"
-        # Add to PATH for this and future steps
-        echo "$HOME/.local/bin" >> $GITHUB_PATH
-
     - name: 'Install Dependencies'
       shell: bash
       run: |

.github/scripts/parse-gemini-output.cjs

@@ -0,0 +1,55 @@
+/**
+ * Parses JSON output from an LLM, handling markdown code blocks and truncated JSON.
+ *
+ * @param {string} rawData - The raw output string from the LLM.
+ * @returns {any} The parsed JSON object.
+ * @throws {Error} If parsing fails completely.
+ */
+module.exports = function parseGeminiOutput(rawData) {
+  if (!rawData) {
+    throw new Error('No data provided to parse.');
+  }
+
+  // 1. Try direct parsing first
+  try {
+    return JSON.parse(rawData);
+  } catch (e) {
+    // Continue to fallback methods
+  }
+
+  // 2. Try to extract from markdown code blocks (```json ... ``` or just ``` ... ```)
+  const codeBlockMatch = rawData.match(/```(?:json)?\s*([\s\S]*?)```/);
+  if (codeBlockMatch) {
+    try {
+      return JSON.parse(codeBlockMatch[1].trim());
+    } catch (e) {
+      // Continue
+    }
+  }
+
+  // 3. Try to extract a JSON object structure using regex
+  const jsonObjectMatch = rawData.match(/\{[\s\S]*\}/);
+  if (jsonObjectMatch) {
+    try {
+      return JSON.parse(jsonObjectMatch[0]);
+    } catch (e) {
+       // Continue
+    }
+  }
+
+  // 4. Last resort: Specific fallback for "description" field (common in PR enrichment)
+  // This handles cases where the JSON might be malformed but the description string is extractable.
+  if (rawData.includes('"description"')) {
+    const descMatch = rawData.match(/"description"\s*:\s*"([\s\S]*?)(?<!\\)"/);
+    if (descMatch) {
+      try {
+        // Manually reconstruct the object
+        return { description: descMatch[1].replace(/\\n/g, '\n').replace(/\\\//g, '/') };
+      } catch (e) {
+        // Ignore
+      }
+    }
+  }
+
+  throw new Error('Failed to parse JSON from output.');
+};

.github/workflows/gemini-triage.yml

@@ -105,24 +105,13 @@ jobs:
                 return;
               }
               const rawData = fs.readFileSync(filePath, 'utf8');
-              // The model may return a JSON object wrapped in markdown.
+              const parseGeminiOutput = require('./.github/scripts/parse-gemini-output.cjs');
+
               let result;
               try {
-                result = JSON.parse(rawData);
+                result = parseGeminiOutput(rawData);
               } catch (e) {
-                // If direct parsing fails, try to extract from markdown code blocks
-                const cleanedData = rawData.trim().replace(/^```json|```$/g, '').trim();
-                try {
-                  result = JSON.parse(cleanedData);
-                } catch (innerError) {
-                  // Final fallback: regex match for the first block
-                  const match = rawData.match(/```(?:json)?\s*([\s\S]*?)\s*```/i);
-                  if (match) {
-                    result = JSON.parse(match[1].trim());
-                  } else {
-                    throw innerError;
-                  }
-                }
+                throw new Error(`Failed to parse triage result: ${e.message}`);
               }
 
               // ---- Start of Validation Block ----

.github/workflows/pr-enrichment.yml

@@ -258,35 +258,13 @@ jobs:
 
             try {
               const rawData = fs.readFileSync('pr_description.json', 'utf8');
+              const parseGeminiOutput = require('./.github/scripts/parse-gemini-output.cjs');
 
               let result;
               try {
-                result = JSON.parse(rawData);
-              } catch (parseError) {
-                // If parsing fails, try to extract JSON from markdown code blocks
-                // This is needed because LLMs sometimes wrap JSON in preamble/postamble
-                const jsonMatch = rawData.match(/```(?:json)?\s*([\s\S]*?)```/);
-                if (jsonMatch) {
-                  try {
-                    result = JSON.parse(jsonMatch[1].trim());
-                  } catch (e) {
-                    // Manual extraction fallback for corrupted/truncated JSON
-                    const descMatch = rawData.match(/"description"\s*:\s*"([\s\S]*?)(?<!\\)"/);
-                    if (descMatch) {
-                      result = { description: descMatch[1].replace(/\\n/g, '\n').replace(/\\\//g, '/') };
-                    } else {
-                      throw new Error(`Failed to parse extracted JSON and extract description: ${e.message}`);
-                    }
-                  }
-                } else {
-                  // Final fallback for raw text without blocks
-                  const descMatch = rawData.match(/"description"\s*:\s*"([\s\S]*?)(?<!\\)"/);
-                  if (descMatch) {
-                    result = { description: descMatch[1].replace(/\\n/g, '\n').replace(/\\\//g, '/') };
-                  } else {
-                    throw new Error(`Failed to parse JSON and extract description: ${parseError.message}`);
-                  }
-                }
+                result = parseGeminiOutput(rawData);
+              } catch (e) {
+                throw new Error(`Failed to parse PR description: ${e.message}`);
               }
 
               // Support both 'description' (normal) and 'reviewComment' (fallback for errors)

app/page.tsx

@@ -13,6 +13,7 @@ import { useState, useCallback } from 'react'
 import HrmConnectionPanel from '@/components/HrmConnectionPanel'
 import TimerDisplay from '@/components/TimerDisplay'
 import { useAudio } from '@/hooks/useAudio'
+import { useTestPageReady } from '@/hooks/useTestPageReady'
 
 // Dynamically import SpotifyDisplay with SSR disabled.
 // This prevents the heavy Spotify SDK logic from blocking the initial server HTML or hydration.
@@ -62,7 +63,6 @@ const Dashboard = () => {
 
   const [docIsManuallyShrunk, setDocIsManuallyShrunk] = useState(false)
   const [audioInitialized, setAudioInitialized] = useState(false)
-<<<<<<< HEAD
 
   // Track the readiness of dynamic components to ensure accurate VRT snapshots.
   // data-ready will only be set to true once all critical sections are hydrated.
@@ -99,8 +99,7 @@ const Dashboard = () => {
       : componentLoadStatus.googleDoc)
 
   const isReady = useTestPageReady(allComponentsReady)
-=======
->>>>>>> origin/leader
+
   const [refreshKey, setRefreshKey] = useState(0)
   const { initializeAudio } = useAudio()
 
@@ -118,6 +117,7 @@ const Dashboard = () => {
   return (
     <Container
       data-testid="dashboard"
+      data-ready={isReady}
       maxWidth="xl"
       onClick={handleInteraction}
       sx={{