test(medium): Fix component test errors and suppress console noise (#9444)

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: arii <342438+arii@users.noreply.github.com>

Author: arii

tests/unit/app/api/internal/token-delivery/route.test.ts

@@ -7,7 +7,7 @@ import { NextRequest } from 'next/server'
 import { SPOTIFY_DEFAULT_TOKEN_EXPIRY_S } from '@/constants/spotify'
 
 // Mock logger
-jest.mock('@/utils/logger.server', () => ({
+jest.mock('@/utils/logger', () => ({
   __esModule: true,
   default: {
     info: jest.fn(),
@@ -36,10 +36,18 @@ describe('POST /api/internal/token-delivery', () => {
   })
 
   beforeEach(() => {
+    jest.spyOn(console, 'info').mockImplementation(() => {})
+    jest.spyOn(console, 'warn').mockImplementation(() => {})
+    jest.spyOn(console, 'error').mockImplementation(() => {})
+
     jest.clearAllMocks()
     global.spotifyService = mockSpotifyService
   })
 
+  afterEach(() => {
+    jest.restoreAllMocks()
+  })
+
   it('should return 401 if secret header is missing or invalid', async () => {
     const req = new NextRequest(
       'http://localhost/api/internal/token-delivery',

tests/unit/app/api/spotify/access-token/route.test.ts

@@ -14,7 +14,13 @@ jest.mock('next-auth/next', () => ({
 const mockedGetServerSession = getServerSession as jest.Mock
 
 describe('API Route: /api/spotify/access-token', () => {
+  beforeEach(() => {
+    jest.spyOn(console, 'error').mockImplementation(() => {})
+    jest.spyOn(console, 'info').mockImplementation(() => {})
+  })
+
   afterEach(() => {
+    jest.restoreAllMocks()
     jest.clearAllMocks()
   })
 

tests/unit/app/api/spotify/devices/route.test.ts

@@ -33,6 +33,9 @@ describe('API Route: /api/spotify/devices', () => {
   let tokenManagerInstance: { getValidAccessToken: jest.Mock }
 
   beforeEach(() => {
+    jest.spyOn(console, 'error').mockImplementation(() => {})
+    jest.spyOn(console, 'info').mockImplementation(() => {})
+
     jest.clearAllMocks()
     // Set up a new mock instance for each test
     MockedSpotifyTokenManager.mockClear()
@@ -44,6 +47,11 @@ describe('API Route: /api/spotify/devices', () => {
     MockedSpotifyTokenManager.mockImplementation(() => tokenManagerInstance)
   })
 
+  afterEach(() => {
+    jest.restoreAllMocks()
+    jest.clearAllMocks()
+  })
+
   it('should return 401 if no user session and no system token is available', async () => {
     mockedGetServerSession.mockResolvedValue(null)
     tokenManagerInstance.getValidAccessToken.mockResolvedValue(null)

tests/unit/app/api/spotify/playlists/route.test.ts

@@ -52,7 +52,13 @@ jest.mock('@spotify/web-api-ts-sdk', () => {
 const mockedGetServerSession = getServerSession as jest.Mock
 
 describe('API Route: /api/spotify/playlists', () => {
+  beforeEach(() => {
+    jest.spyOn(console, 'error').mockImplementation(() => {})
+    jest.spyOn(console, 'warn').mockImplementation(() => {})
+  })
+
   afterEach(() => {
+    jest.restoreAllMocks()
     jest.clearAllMocks()
   })
 

tests/unit/components/GoogleDocViewer.test.tsx

@@ -48,10 +48,16 @@ describe('GoogleDocViewer', () => {
   })
 
   it('renders nothing if embedUrl is invalid', () => {
-    const { container } = render(
-      <GoogleDocViewer title="Test Doc" embedUrl="invalid-url" />
-    )
-    expect(container).toBeEmptyDOMElement()
+    const errorSpy = jest.spyOn(console, 'error').mockImplementation(() => {})
+    try {
+      const { container } = render(
+        <GoogleDocViewer title="Test Doc" embedUrl="invalid-url" />
+      )
+      expect(container).toBeEmptyDOMElement()
+      expect(errorSpy).toHaveBeenCalledWith('Invalid URL:', 'invalid-url')
+    } finally {
+      errorSpy.mockRestore()
+    }
   })
 
   it('renders nothing if embedUrl is empty', () => {

tests/unit/components/SpotifyDisplay.test.tsx

@@ -165,8 +165,13 @@ describe('SpotifyDisplay', () => {
     })
     expect(loginButton).toBeInTheDocument()
 
-    // Simulate user click
-    await userEvent.click(loginButton)
+    const logSpy = jest.spyOn(console, 'log').mockImplementation(() => {})
+    try {
+      // Simulate user click
+      await userEvent.click(loginButton)
+    } finally {
+      logSpy.mockRestore()
+    }
 
     // Assert that signIn was called correctly
     expect(mockedSignIn).toHaveBeenCalledTimes(1)

tests/unit/hooks/useBluetoothHRM.race.test.ts

@@ -30,6 +30,19 @@ jest.mock('js-cookie', () => ({
 }))
 
 describe('useBluetoothHRM Race Conditions', () => {
+  let infoSpy: jest.SpyInstance
+  let warnSpy: jest.SpyInstance
+
+  beforeAll(() => {
+    infoSpy = jest.spyOn(console, 'info').mockImplementation(() => {})
+    warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {})
+  })
+
+  afterAll(() => {
+    infoSpy.mockRestore()
+    warnSpy.mockRestore()
+  })
+
   const originalNavigator = global.navigator
   let mockRequestDevice: jest.Mock
   let mockGattConnect: jest.Mock

tests/unit/hooks/usePersistentStorage.test.ts

@@ -115,40 +115,50 @@ describe('usePersistentStorage', () => {
   })
 
   it('should not fallback to cookies when localStorage is available but write fails', () => {
-    // Mock localStorage: setItem works for the test key (so checkLocalStorage passes)
-    // but fails for the data key.
-    Object.defineProperty(window, 'localStorage', {
-      value: {
-        setItem: jest.fn((key, _value) => {
-          if (key === '__hrm_test__') {
-            return // Success for check
-          }
-          throw new Error('QuotaExceeded')
-        }),
-        getItem: jest.fn(),
-        removeItem: jest.fn(),
-        clear: jest.fn(),
-      },
-      writable: true,
-      configurable: true,
-    })
-
-    const { result } = renderHook(() =>
-      usePersistentStorage(TEST_KEY, INITIAL_VALUE, {
-        enableCookieFallback: true,
+    const consoleSpy = jest.spyOn(console, 'error').mockImplementation(() => {})
+
+    try {
+      // Mock localStorage: setItem works for the test key (so checkLocalStorage passes)
+      // but fails for the data key.
+      Object.defineProperty(window, 'localStorage', {
+        value: {
+          setItem: jest.fn((key, _value) => {
+            if (key === '__hrm_test__') {
+              return // Success for check
+            }
+            throw new Error('QuotaExceeded')
+          }),
+          getItem: jest.fn(),
+          removeItem: jest.fn(),
+          clear: jest.fn(),
+        },
+        writable: true,
+        configurable: true,
       })
-    )
 
-    act(() => {
-      const [, setValue] = result.current
-      setValue(UPDATED_VALUE)
-    })
+      const { result } = renderHook(() =>
+        usePersistentStorage(TEST_KEY, INITIAL_VALUE, {
+          enableCookieFallback: true,
+        })
+      )
 
-    expect(window.localStorage.setItem).toHaveBeenCalledWith(
-      TEST_KEY,
-      JSON.stringify(UPDATED_VALUE)
-    )
-    expect(Cookies.set).not.toHaveBeenCalled()
+      act(() => {
+        const [, setValue] = result.current
+        setValue(UPDATED_VALUE)
+      })
+
+      expect(window.localStorage.setItem).toHaveBeenCalledWith(
+        TEST_KEY,
+        JSON.stringify(UPDATED_VALUE)
+      )
+      expect(Cookies.set).not.toHaveBeenCalled()
+      expect(consoleSpy).toHaveBeenCalledWith(
+        'LocalStorage write failed:',
+        expect.any(Error)
+      )
+    } finally {
+      consoleSpy.mockRestore()
+    }
   })
 
   it('should load initial value from localStorage if present', () => {

tests/unit/hooks/useSpotifyWebPlayback.test.ts

@@ -52,12 +52,20 @@ describe('useSpotifyWebPlayback', () => {
   let mockAddError: jest.Mock
 
   beforeEach(() => {
+    jest.spyOn(console, 'log').mockImplementation(() => {})
+    jest.spyOn(console, 'error').mockImplementation(() => {})
+
     jest.clearAllMocks()
     mockAddError = jest.fn()
     mockUseError.mockReturnValue({ addError: mockAddError })
     mockUseSpotifyAuth.mockReturnValue({ status: 'authenticated' })
   })
 
+  afterEach(() => {
+    jest.restoreAllMocks()
+    jest.clearAllMocks()
+  })
+
   it('should initialize the SDK and connect the player on mount', async () => {
     mockFetchWithRetry.mockResolvedValue({
       ok: true,

tests/unit/lib/env.test.ts

@@ -46,12 +46,17 @@ describe('Environment Variables', () => {
   })
 
   it('should throw an error for invalid environment variables', async () => {
-    process.env.NODE_ENV = 'test'
-    process.env.NEXTAUTH_URL = 'invalid-url'
-    process.env.NEXTAUTH_SECRET = 'secret'
-    process.env.SPOTIFY_CLIENT_ID = 'id'
-    process.env.SPOTIFY_CLIENT_SECRET = 'secret'
-    await expect(import('../../../lib/env')).rejects.toThrow(z.ZodError)
+    const errorSpy = jest.spyOn(console, 'error').mockImplementation(() => {})
+    try {
+      process.env.NODE_ENV = 'test'
+      process.env.NEXTAUTH_URL = 'invalid-url'
+      process.env.NEXTAUTH_SECRET = 'secret'
+      process.env.SPOTIFY_CLIENT_ID = 'id'
+      process.env.SPOTIFY_CLIENT_SECRET = 'secret'
+      await expect(import('../../../lib/env')).rejects.toThrow(z.ZodError)
+    } finally {
+      errorSpy.mockRestore()
+    }
   })
 
   it('should derive SPOTIFY_CALLBACK_URL from NEXTAUTH_URL if not provided', async () => {
@@ -67,11 +72,16 @@ describe('Environment Variables', () => {
   })
 
   it('should throw an error if Spotify credentials are provided but callback URL cannot be determined', async () => {
-    process.env.NODE_ENV = 'test'
-    process.env.NEXTAUTH_SECRET = 'secret'
-    process.env.SPOTIFY_CLIENT_ID = 'id'
-    process.env.SPOTIFY_CLIENT_SECRET = 'secret'
-    delete process.env.NEXTAUTH_URL
-    await expect(import('../../../lib/env')).rejects.toThrow(z.ZodError)
+    const errorSpy = jest.spyOn(console, 'error').mockImplementation(() => {})
+    try {
+      process.env.NODE_ENV = 'test'
+      process.env.NEXTAUTH_SECRET = 'secret'
+      process.env.SPOTIFY_CLIENT_ID = 'id'
+      process.env.SPOTIFY_CLIENT_SECRET = 'secret'
+      delete process.env.NEXTAUTH_URL
+      await expect(import('../../../lib/env')).rejects.toThrow(z.ZodError)
+    } finally {
+      errorSpy.mockRestore()
+    }
   })
 })