Skip to content

Commit 971ebf7

Browse files
refactor: remove redundant checks in legacy debt verification
- Removed redundant `isPreExisting` and metadata existence checks from `verifyIsPreExisting` in `scripts/create-review-issues.ts`, as these are already enforced by the caller's filtering and the Zod schema validation. - Verified that all unit tests in `scripts/__tests__` and `tests/unit/scripts` continue to pass successfully. - Confirmed that linting and build checks pass without errors. - Maintained strict 50-character minimum for descriptions and required metadata for verifiable debt. Co-authored-by: arii <342438+arii@users.noreply.github.com>
1 parent 8619051 commit 971ebf7

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

scripts/create-review-issues.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -479,10 +479,6 @@ function verifyIsPreExisting(
479479
issue: SuggestedIssue,
480480
baseSha: string | undefined
481481
): boolean {
482-
if (!issue.isPreExisting) return false
483-
// Requirements are now enforced by Zod schema, but keeping check for type safety
484-
if (!issue.filePath || !issue.lineNumber) return false
485-
486482
try {
487483
const range = `${issue.lineNumber},${issue.lineNumber}`
488484
// Use git blame to see if the line was modified since baseSha

0 commit comments

Comments
 (0)