chore(vrt): Refactor visual regression tests for stability and code reduction - #9657
Conversation
…eduction - Remove over-engineered `update-pr-branches.sh` - Flatten `masks.ts` by removing redundant `getHrMasks`, `getTimerMasks`, `getSpotifyMasks` and updating consumers to use `getDynamicContentMasks` directly. - Merge `waitForFontsLoaded` and duplicate `waitForVRTReady` logic into a single cohesive `waitForVRTReady` hook in `waits.ts`, ensuring `domcontentloaded` is used properly without flaky catch blocks. - Delete overly verbose comments in `vrt-components.spec.ts`. - Retain stricter Playwright VRT `maxDiffPixelRatio` at `0.02` using the mask-heavy approach. Co-authored-by: arii <342438+arii@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
👋 Welcome to HRM!Thanks for your contribution. This repository uses Gemini AI for automated triage, code review, and generation. 🤖 Gemini Manual Trigger Quick Reference
For more details and GitHub CLI examples, see the Manual Trigger Guide. |
ℹ️ Gemini Review DisabledAutomatic review is currently disabled via Via Comment: Via GitHub Actions:
Via GitHub CLI: gh workflow run reusable-gemini-review.yml -f pr_number=9657🤖 Gemini Manual Trigger GuideTo re-enable: Set repository variable |
🤖 Gemini Review SkippedReview was skipped for the following reason: 🤖 Gemini Manual Trigger Guide |
arii
added
the
not reviewed
Fixed the Prettier formatting issue caused by removing redundant mask functions from array expansions, condensing them to single lines to resolve the `pnpm run lint` CI failure. Co-authored-by: arii <342438+arii@users.noreply.github.com>
🤖 Gemini Review SkippedReview was skipped for the following reason: 🤖 Gemini Manual Trigger Guide |
arii
added
not reviewed
2dcc612
into
fix-vrt-flakiness-and-google-doc-leak-13121355426496306477-1708615312242433116
1 participant
Implemented directives from code review to consolidate VRT testing and remove unnecessary features and duplicated helpers, adhering strictly to the strict-threshold model without losing safety checks.
PR created automatically by Jules for task 2309313961698362375 started by @arii