Refactor: Polish Gemini UI review and address code review directives - #9665
Conversation
- Refactor `comment-ops.yml` routing to use a bash loop to prevent regex bloat. - Replace fragile `gh pr comment` execFileSync call in `run-ui-review.ts` with a robust `@octokit/rest` implementation. - Import proper `ServerMessage` definitions instead of relying on hardcoded type strings and payloads. - Replace disk-based snapshot file management with an in-memory `Buffer` passed directly to the Gemini API, improving containerized CI efficiency. - Remove redundant boilerplate comments and properly handle undefined AI responses. Co-authored-by: arii <342438+arii@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
👋 Welcome to HRM!Thanks for your contribution. This repository uses Gemini AI for automated triage, code review, and generation. 🤖 Gemini Manual Trigger Quick Reference
For more details and GitHub CLI examples, see the Manual Trigger Guide. |
ℹ️ Gemini Review DisabledAutomatic review is currently disabled via Via Comment: Via GitHub Actions:
Via GitHub CLI: gh workflow run reusable-gemini-review.yml -f pr_number=9665🤖 Gemini Manual Trigger GuideTo re-enable: Set repository variable |
🤖 Gemini Review SkippedReview was skipped for the following reason: 🤖 Gemini Manual Trigger Guide |
arii
added
the
not reviewed
1 participant
This PR applies Principal Engineer directives to refine the automated Gemini UI Review scripts and comment bot workflows introduced in PR #9577. It simplifies CI logic, enhances type-safety by reusing existing backend data models, addresses shadowing/stale logic, and fundamentally improves system robustness by replacing CLI shelling with the
OctokitAPI and utilizing in-memory buffers for Playwright screenshots to bypass filesystem handling entirely.PR created automatically by Jules for task 1136741796143295183 started by @arii