Skip to content

Fix: Spotify UI and playback fixes from PR review - #9667

Merged
arii merged 1 commit into
ui-ux-spotify-track-selection-optimization-14059094504088146715from
ui-ux-spotify-track-selection-optimization-14059094504088146715-11193514009751959609
Mar 26, 2026
Merged

Fix: Spotify UI and playback fixes from PR review#9667
arii merged 1 commit into
ui-ux-spotify-track-selection-optimization-14059094504088146715from
ui-ux-spotify-track-selection-optimization-14059094504088146715-11193514009751959609

Conversation

@arii

@arii arii commented Mar 23, 2026

Copy link
Copy Markdown
Owner

This PR implements the requested code reductions and architectural fixes from the PR review audit.

  • The /api/spotify/playlists/[playlistId]/tracks route returns both duration and duration_ms to avoid client breaking changes.
  • TrackListItem now includes an alt tag on its Avatar for better accessibility.
  • Duplicated offset definitions between types/core.ts and types/websocket.ts have been fixed by making SpotifyCommandMessage extend SpotifyCommandParameters.
  • All tests (lint, unit, and visual) have been successfully run and pass.

PR created automatically by Jules for task 11193514009751959609 started by @arii

- Added `duration` fallback to Spotify tracks API route for backwards compatibility.
- Added accessibility `alt` tag to `TrackListItem`.
- Consolidated `SpotifyCommandMessage` to properly extend `SpotifyCommandParameters`.

Co-authored-by: arii <342438+arii@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Welcome to HRM!

Thanks for your contribution. This repository uses Gemini AI for automated triage, code review, and generation.

🤖 Gemini Manual Trigger Quick Reference

Command Action
@gemini-bot Run AI Code Review (PR only)
@gemini-enrich Run PR Enrichment (PR only)
@gemini-triage Run Issue Triage
@gemini-coder <task> Generate Code
@create-review-issues Create issues from review (PR only)
@gemini-help Show this help message
@pr-squash Squash PR commits (PR only)
@conflict-resolve Resolve merge conflicts (PR only)

For more details and GitHub CLI examples, see the Manual Trigger Guide.

@github-actions

Copy link
Copy Markdown
Contributor

ℹ️ Gemini Review Disabled

Automatic review is currently disabled via GEMINI_ENABLE_PR_REVIEW. To run review manually:

Via Comment:

@gemini-bot

Via GitHub Actions:

  1. Go to Actions → Reusable Gemini Review
  2. Click "Run workflow"
  3. Enter PR number: 9667

Via GitHub CLI:

gh workflow run reusable-gemini-review.yml -f pr_number=9667

🤖 Gemini Manual Trigger Guide

To re-enable: Set repository variable GEMINI_ENABLE_PR_REVIEW=true

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Gemini Review Skipped

Review was skipped for the following reason: Gemini review is globally disabled

🤖 Gemini Manual Trigger Guide

@arii arii added the not reviewed The review could not be performed or completed successfully. label Mar 23, 2026
@arii
arii marked this pull request as ready for review March 26, 2026 02:59
@arii
arii merged commit a79e90a into ui-ux-spotify-track-selection-optimization-14059094504088146715 Mar 26, 2026
29 checks passed
@arii
arii deleted the ui-ux-spotify-track-selection-optimization-14059094504088146715-11193514009751959609 branch March 26, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not reviewed The review could not be performed or completed successfully.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant