Let parser handle running status

Author: arirusso

lib/nibbler/message_builder.rb

@@ -54,15 +54,13 @@ def sysex?
 
     # Can this builder build a message from the given bytes?
     # @param [Array<Integer>] bytes The bytes to build a message with
-    # @param [Integer] running_status Build the message using running status when running status is present
     # @return [Boolean]
-    def can_build_next?(bytes, running_status: nil)
+    def can_build_next?(bytes)
       if sysex?
         # check that there's a sysex end byte
         bytes.any? { |byte| byte == 0xF7 }
       else
-        bytes_to_test = running_status ? [running_status] + bytes : bytes
-        potential_data_bytes = bytes_to_test.drop(1)
+        potential_data_bytes = bytes.drop(1)
         next_status_index = potential_data_bytes.index { |byte| Util.status_byte?(byte) }
         bytes_to_test = next_status_index ? potential_data_bytes.slice(0, next_status_index) : potential_data_bytes
         length_of_data = @length_in_bytes - 1

lib/nibbler/parser.rb

@@ -64,7 +64,7 @@ def processable?(pointer)
     def handle_running_status(pointer, report)
       status_nibbles = Util::Conversion.numeric_byte_to_numeric_nibbles(@running_status)
       builder = message_builder_for(status_nibbles)
-      if builder.can_build_next?(@buffer, running_status: @running_status)
+      if builder.can_build_next?([@running_status] + @buffer)
         build_running_status_message(builder, pointer, report, status_nibble2: status_nibbles[1])
         0
       else

spec/message_builder_spec.rb

@@ -78,37 +78,6 @@
           end
         end
       end
-
-      context 'when running status' do
-        let(:result) { builder.can_build_next?(bytes, running_status: 0x90) }
-
-        context 'when valid' do
-          let(:bytes) { [0x40, 0x40] }
-          let(:status_nibble) { 0x9 }
-
-          it 'returns true' do
-            expect(result).to eq(true)
-          end
-        end
-
-        context 'when incomplete' do
-          let(:bytes) { [0x40] }
-          let(:status_nibble) { 0x9 }
-
-          it 'returns false' do
-            expect(result).to eq(false)
-          end
-        end
-
-        context 'when invalid' do
-          let(:bytes) { [0x40, 0x80] }
-          let(:status_nibble) { 0x9 }
-
-          it 'returns false' do
-            expect(result).to eq(false)
-          end
-        end
-      end
     end
 
     context 'when sysex message' do