Feat(eos_designs): Add support for ipv6 addresses in l3_interfaces in network_services (#6876)

Co-authored-by: Mahesh Kumar <122076792+MaheshGSLAB@users.noreply.github.com>
Co-authored-by: laxmikantchintakindi <159624484+laxmikantchintakindi@users.noreply.github.com>
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>

Author: 4 people

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/host_vars/net-srv-l3-interfaces-ipv6-addresses-length-mismatch.yml

@@ -0,0 +1,36 @@
+---
+# Minimum config to only test the specific feature.
+type: l3leaf
+l3leaf:
+  defaults:
+    loopback_ipv4_pool: 192.168.255.0/24
+    loopback_ipv4_offset: 8
+    vtep_loopback_ipv4_pool: 192.168.254.0/24
+    virtual_router_mac_address: 00:dc:00:00:00:0a
+  nodes:
+    - name: net-srv-l3-interfaces-ipv6-addresses-length-mismatch
+      id: 101
+      bgp_as: 101
+
+tenants:
+  - name: TENANT_B
+    vrfs:
+      - name: TENANT_B_WAN
+        vrf_id: 20
+        l3_interfaces:
+          - description: TENANT_B_SITE_3
+            enabled: true
+            interfaces:
+              - Ethernet6
+            # ipv6_addresses length (2) does not match nodes length (1)
+            ip_addresses:
+              - 192.168.48.4/31
+            ipv6_addresses:
+              - 2001:db8::1/64
+              - 2001:db8::2/64
+            nodes:
+              - net-srv-l3-interfaces-ipv6-addresses-length-mismatch
+
+expected_error_message: >-
+  Length of 'ipv6_addresses' (2) must match length of 'nodes' (1)
+  for l3_interfaces under VRF 'TENANT_B_WAN' in tenant 'TENANT_B'.

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/host_vars/net-srv-l3-po-sub-interface-without-ip.yml

@@ -38,4 +38,5 @@ tenants:
             node: net-srv-l3-po-sub-interface-without-ip
 
 expected_error_message: >-
-  'l3leaf.nodes[name=net-srv-l3-po-sub-interface-without-ip].l3_port_channels[name=Port-Channel1111.100].ip_address' is required but was not found.
+  'l3leaf.nodes[name=net-srv-l3-po-sub-interface-without-ip].l3_port_channels[name=Port-Channel1111.100].ip_address or ipv6_addresses'
+  is required but was not found.

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/hosts.yml

@@ -484,6 +484,7 @@ all:
             monitor-connectivity-local-interfaces-not-in-interface-sets:
             monitor-connectivity-vrf-host-local-interfaces-not-in-interface-sets:
             monitor-connectivity-vrf-local-interfaces-not-in-interface-sets:
+            net-srv-l3-interfaces-ipv6-addresses-length-mismatch:
             net-srv-l3-po-sub-interface-with-members:
             net-srv-l3-po-sub-interface-with-mode:
             net-srv-l3-po-sub-interface-with-mtu:

ansible_collections/arista/avd/extensions/molecule/eos_designs_unit_tests/intended/configs/network-services-l3-interfaces.cfg

@@ -0,0 +1,96 @@
+!
+no enable password
+no aaa root
+!
+vlan internal order ascending range 1006 1199
+!
+transceiver qsfp default-mode 4x10G
+!
+service routing protocols model multi-agent
+!
+hostname network-services-l3-interfaces
+!
+vrf instance L3INTF_TEST
+!
+vrf instance MGMT
+!
+interface Ethernet10
+   description ipv6-only-default-vrf
+   no shutdown
+   no switchport
+   ipv6 address 2001:db8:10::1/64
+!
+interface Ethernet11
+   description dual-stack-default-vrf
+   no shutdown
+   no switchport
+   ip address 10.0.11.1/31
+   ipv6 address 2001:db8:11::1/64
+   ipv6 access-group TEST-IPV6-ACL-STATIC-IN in
+!
+interface Ethernet12
+   description ipv6-only-non-default-vrf
+   no shutdown
+   no switchport
+   vrf L3INTF_TEST
+   ipv6 address 2001:db8:12::1/64
+   ipv6 access-group TEST-IPV6-ACL-WITH-IP-FIELDS-OUT_Ethernet12 out
+!
+interface Loopback0
+   description ROUTER_ID
+   no shutdown
+   ip address 192.168.200.1/32
+!
+interface Loopback1
+   description VXLAN_TUNNEL_SOURCE
+   no shutdown
+   ip address 192.168.201.1/32
+!
+interface Vxlan1
+   description network-services-l3-interfaces_VTEP
+   vxlan source-interface Loopback1
+   vxlan udp-port 4789
+   vxlan vrf default vni 1
+   vxlan vrf L3INTF_TEST vni 2
+!
+ip virtual-router mac-address 00:dc:00:00:00:0b
+!
+ipv6 access-list TEST-IPV6-ACL-STATIC-IN
+   10 deny ipv6 any any
+!
+ipv6 access-list TEST-IPV6-ACL-WITH-IP-FIELDS-OUT_Ethernet12
+   10 permit ipv6 host 2001:db8:12::1 any
+!
+ip routing
+ip routing vrf L3INTF_TEST
+no ip routing vrf MGMT
+!
+ip prefix-list PL-LOOPBACKS-EVPN-OVERLAY
+   seq 10 permit 192.168.200.0/24 eq 32
+   seq 20 permit 192.168.201.0/24 eq 32
+!
+ipv6 unicast-routing
+!
+ipv6 unicast-routing vrf L3INTF_TEST
+!
+route-map RM-CONN-2-BGP permit 10
+   match ip address prefix-list PL-LOOPBACKS-EVPN-OVERLAY
+!
+router bfd
+   multihop interval 300 min-rx 300 multiplier 3
+!
+router bgp 200
+   router-id 192.168.200.1
+   update wait-install
+   no bgp default ipv4-unicast
+   maximum-paths 4
+   redistribute connected route-map RM-CONN-2-BGP
+   !
+   vrf L3INTF_TEST
+      rd 192.168.200.1:2
+      route-target import evpn 2:2
+      route-target export evpn 2:2
+      router-id 192.168.200.1
+      redistribute connected
+!
+end

ansible_collections/arista/avd/extensions/molecule/eos_designs_unit_tests/intended/configs/network-services-l3-port-channels.cfg

@@ -70,6 +70,20 @@ interface Port-Channel23
    no shutdown
    no switchport
 !
+interface Port-Channel33
+   description ipv6-cloud_Po33
+   no shutdown
+   no switchport
+   ipv6 address 2001:db8:1::1/64
+!
+interface Port-Channel44
+   description dual-stack-cloud_Po44
+   no shutdown
+   no switchport
+   ip address 10.10.30.2/29
+   ipv6 address 2001:db8:2::1/64
+   ipv6 access-group in6ACL in
+!
 interface Port-Channel77
    description L3 Port-Channel without ip_address
    no shutdown
@@ -150,6 +164,14 @@ interface Port-Channel1113
    ip address 1.1.1.13/29
    ip ospf area 0.0.0.0
 !
+interface Port-Channel2000
+   description ipv6-cloud-testing_Po2000
+   no shutdown
+   no switchport
+   vrf TESTING
+   ipv6 address 2001:db8:3::1/64
+   ipv6 access-group out6ACL_Port-Channel2000 out
+!
 interface Ethernet4
    description man descr inet-clout eth8
    no shutdown
@@ -193,6 +215,21 @@ interface Ethernet24
    no shutdown
    channel-group 23 mode on
 !
+interface Ethernet33
+   description ipv6-cloud_Ethernet33
+   no shutdown
+   channel-group 33 mode active
+!
+interface Ethernet45
+   description dual-stack-cloud_Ethernet45
+   no shutdown
+   channel-group 44 mode active
+!
+interface Ethernet46
+   description ipv6-cloud-testing_Ethernet46
+   no shutdown
+   channel-group 2000 mode active
+!
 interface Ethernet77
    description underlay-peer_Ethernet77
    no shutdown
@@ -228,6 +265,12 @@ interface Vxlan1
 !
 ip virtual-router mac-address 00:dc:00:00:00:0a
 !
+ipv6 access-list in6ACL
+   10 deny ipv6 any any
+!
+ipv6 access-list out6ACL_Port-Channel2000
+   10 permit ipv6 host 2001:db8:3::1 any
+!
 ip access-list inACL
    10 deny ip any any
 !
@@ -243,6 +286,9 @@ ip prefix-list PL-LOOPBACKS-EVPN-OVERLAY
    seq 10 permit 192.168.255.0/24 eq 32
    seq 20 permit 192.168.254.0/24 eq 32
 !
+ipv6 unicast-routing
+ipv6 unicast-routing vrf TESTING
+!
 route-map RM-CONN-2-BGP permit 10
    match ip address prefix-list PL-LOOPBACKS-EVPN-OVERLAY
 !

ansible_collections/arista/avd/extensions/molecule/eos_designs_unit_tests/intended/structured_configs/network-services-l3-interfaces.yml

@@ -0,0 +1,146 @@
+aaa_root:
+  disabled: true
+config_end: true
+enable_password:
+  disabled: true
+ethernet_interfaces:
+- name: Ethernet10
+  description: ipv6-only-default-vrf
+  shutdown: false
+  ipv6_addresses:
+  - 2001:db8:10::1/64
+  metadata:
+    peer_type: l3_interface
+  switchport:
+    enabled: false
+- name: Ethernet11
+  description: dual-stack-default-vrf
+  shutdown: false
+  ip_address: 10.0.11.1/31
+  ipv6_addresses:
+  - 2001:db8:11::1/64
+  ipv6_access_group_in: TEST-IPV6-ACL-STATIC-IN
+  metadata:
+    peer_type: l3_interface
+  switchport:
+    enabled: false
+- name: Ethernet12
+  description: ipv6-only-non-default-vrf
+  shutdown: false
+  vrf: L3INTF_TEST
+  ipv6_addresses:
+  - 2001:db8:12::1/64
+  ipv6_access_group_out: TEST-IPV6-ACL-WITH-IP-FIELDS-OUT_Ethernet12
+  metadata:
+    peer_type: l3_interface
+  switchport:
+    enabled: false
+hostname: network-services-l3-interfaces
+ip_igmp_snooping:
+  globally_enabled: true
+ip_routing: true
+ip_virtual_router_mac_address: 00:dc:00:00:00:0b
+ipv6_access_lists:
+- name: TEST-IPV6-ACL-STATIC-IN
+  entries:
+  - protocol: ipv6
+    source: any
+    destination: any
+    sequence: 10
+    action: deny
+- name: TEST-IPV6-ACL-WITH-IP-FIELDS-OUT_Ethernet12
+  entries:
+  - protocol: ipv6
+    source: 2001:db8:12::1
+    destination: any
+    sequence: 10
+    action: permit
+ipv6_unicast_routing: true
+loopback_interfaces:
+- name: Loopback0
+  description: ROUTER_ID
+  shutdown: false
+  ip_address: 192.168.200.1/32
+- name: Loopback1
+  description: VXLAN_TUNNEL_SOURCE
+  shutdown: false
+  ip_address: 192.168.201.1/32
+metadata:
+  is_deployed: true
+  fabric_name: EOS_DESIGNS_UNIT_TESTS
+prefix_lists:
+- name: PL-LOOPBACKS-EVPN-OVERLAY
+  sequence_numbers:
+  - sequence: 10
+    action: permit 192.168.200.0/24 eq 32
+  - sequence: 20
+    action: permit 192.168.201.0/24 eq 32
+route_maps:
+- name: RM-CONN-2-BGP
+  sequence_numbers:
+  - sequence: 10
+    type: permit
+    match:
+    - ip address prefix-list PL-LOOPBACKS-EVPN-OVERLAY
+router_bfd:
+  multihop:
+    interval: 300
+    min_rx: 300
+    multiplier: 3
+router_bgp:
+  as: '200'
+  router_id: 192.168.200.1
+  maximum_paths:
+    paths: 4
+  updates:
+    wait_install: true
+  bgp:
+    default:
+      ipv4_unicast: false
+  redistribute:
+    connected:
+      enabled: true
+      route_map: RM-CONN-2-BGP
+  vrfs:
+  - name: L3INTF_TEST
+    rd: 192.168.200.1:2
+    route_targets:
+      import:
+      - address_family: evpn
+        route_targets:
+        - '2:2'
+      export:
+      - address_family: evpn
+        route_targets:
+        - '2:2'
+    router_id: 192.168.200.1
+    redistribute:
+      connected:
+        enabled: true
+service_routing_protocols_model: multi-agent
+transceiver_qsfp_default_mode_4x10: true
+vlan_internal_order:
+  allocation: ascending
+  range:
+    beginning: 1006
+    ending: 1199
+vrfs:
+- name: MGMT
+  ip_routing: false
+- name: L3INTF_TEST
+  ip_routing: true
+  ipv6_routing: true
+  metadata:
+    tenants:
+    - L3INTF
+vxlan_interface:
+  vxlan1:
+    description: network-services-l3-interfaces_VTEP
+    vxlan:
+      source_interface: Loopback1
+      udp_port: 4789
+      vrfs:
+      - name: default
+        vni: 1
+      - name: L3INTF_TEST
+        vni: 2