In menu "HA discovery" Unit of Measure for some values are missing.

[WO15]

Describe the bug

In menu "HA discovery", when selecting Advanced Mode.
You can see the defaults settings for the HA (Home Assistant) Names and the Unit of Measurement (UoM) and edit these if needed.
For several values, there is, with the default settings, no UoM is indicated

For these values you see in Home Assistant, when you look at the history, a color bar with all the values as separate colors. This is OK for discrete values like Faninfo (showing high, low etc level) with approx 5 possible values, however less ideal for "analog" values like temperature and humidity, where you would prefer a graph.

I have manually added the UoM for the values I am interested in, having them set by default, would be more convenient.
For Itho CVE-S Optima 2, values with missing UoMs are:

• temp: Uom = ⁰C
• hum: Uom = %
• RelativeHumidity: Uom = %
• Temperature: Uom = ⁰C
• ppmw: Uom = ppm (weight) # Assume this are parts per milion water in 1 kg of air, also known as Static Humidity, if so mg/kg would also be correct.

Off-topic: ppmw value is probably used by Itho box to regulate fanspeed for humidity, see under Itho settings: "Rise in absolute humidity (X) at which it goes to high (mg_kg)".

Nit picking:
Absolute humidity (AH) is actually: weight of water in m³ of air
Static humidity (SH) is: weight of water in 1 kg of air
AH not influence by air-temperature vs RH very much influenced by air-temperature
SH is also not influence on air pressure so most suitable/stable to monitor the actual water content in de air.

To Reproduce

Steps to reproduce the behaviour:

1. Go to menu item "HA discovery"
2. check checkbox "Advanced mode"
3. in column "Unit of Measurements", unit of measurements for several values are missing.

Expected behaviour

see above.

Screenshots

not relevant

Device information

Current firmware version: 2.9.0-beta13
Hardware revision: 2
Itho device type: CVE-Silent
Itho hw version: 57
Itho fw version: 27
Manufacturer: 0

Debug logging

Please provide debug logging from the debug page if possible:
not relevant

Desktop (please complete the following information):

• not relevant

Smartphone (please complete the following information):

• not relevant

[arjenhiemstra]

Hi, thanks for this issue.

The UoM's are only filled when they are present in the device files (https://github.com/arjenhiemstra/ithowifi/tree/master/software/NRG_itho_wifi/main/devices)
They are extracted programatically.

To generate the name, the UoM is removed here:

ithowifi/software/NRG_itho_wifi/main/webroot_source/controls_js_sources/javascript.js

Lines 1688 to 1696 in 08a45f3

	// HA Name (editable, unit of measurement removed)
	const unitMatch = key.match(/\(([^)]+)\)$/); // Extract unit in parentheses
	const cleanName = key.replace(/\s*\([^)]+\)$/, ""); // Remove unit from name
	const nameInput$ = $("<input>", {
	type: "text",
	value: cleanName,
	placeholder: "Name",
	});
	row$.append($("<td>").append(nameInput$));

For the UoM, this is extracted here:

ithowifi/software/NRG_itho_wifi/main/webroot_source/controls_js_sources/javascript.js

Lines 1724 to 1731 in 08a45f3

	// Unit of Measurement (editable, advanced, pre-filled if present)
	const unitInput$ = $("<input>", {
	type: "text",
	class: "advanced hidden",
	placeholder: "Unit of Measurement",
	value: unitMatch ? unitMatch[1] : "",
	});
	row$.append($("<td>").addClass("advanced hidden").append(unitInput$));

It is of course possible to change the device files (ie. hum en temp) to include UoM but the reason hum and temp are (still) here is for backwards compatibility. In almost all cases the information was made redundant once it became possible to readout the status values from the itho firmware directly.

About ppmw; this was added by a user and is calculated here:

ithowifi/software/NRG_itho_wifi/main/generic_functions.cpp

Lines 37 to 39 in 08a45f3

	auto b = 611.21 * pow(2.7183, ((18.678 - ithoTemp / 234.5) * ithoTemp) / (257.14 + ithoTemp));
	auto ppmw = b / (101325 - b) * ithoHum / 100 * 0.62145 * 1000000;
	root["ppmw"] = static_cast<int>(ppmw + 0.5);

I'm not sure about is uses and if it is correct or not.

ppmw value is probably used by Itho box to regulate fanspeed for humidity, see under Itho settings: "Rise in absolute humidity (X) at which it goes to high (mg_kg)"

these are unrelated. The first is as described calculated, the latter is a setting provided by the itho firmware and passed through as is.

Nit picking:

Ok, thanks. If anything needs to be changed or can be improved, I'm all ears! Feel free to create a PR!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.