Skip to content

Improve LDT API #5

@tsunrise

Description

@tsunrise

Summary

First, we need to make clear in the doc that the FRI in this repo is simply a round function. The complete FRI function requires an IOP system, and has been implemented as a built-in feature in ark-bcs library.

As I work on the ark-bcs code which uses this library, I do think we need to rename some parameters' name. For example, see the following function signature

pub fn consistency_check(
        fri_parameters: &FRIParameters<F>,
        queried_coset_indices: &[usize],
        queries: &[Radix2CosetDomain<F>],
        queried_evaluations: &[Vec<F>],
        alphas: &[F],
        final_polynomial_domain: &Radix2CosetDomain<F>,
        final_polynomial: &DensePolynomial<F>,

queried_coset_indices and queries are very confusing name. We need to specify where they come from, and the meaning of them.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions