lint

Author: mmaker

circuit/src/allocator.rs

@@ -59,7 +59,9 @@ impl<T: Clone + Unit> VarAllocator<T> {
     #[must_use]
     pub fn allocate_vars<const N: usize>(&self) -> [FieldVar; N] {
         let mut buf = [FieldVar::default(); N];
-        for x in buf.iter_mut() {  *x = self.new_field_var() };
+        for x in &mut buf {
+            *x = self.new_field_var();
+        }
         buf
     }
 

circuit/src/permutation.rs

@@ -14,9 +14,11 @@ pub struct PermutationInstanceBuilder<T, const WIDTH: usize> {
     constraints: Arc<RwLock<PermutationInstance<WIDTH>>>,
 }
 
+type QueryAnswerPair<U, const WIDTH: usize> = ([U; WIDTH], [U; WIDTH]);
+
 #[derive(Clone)]
 pub struct PermutationWitnessBuilder<P: Permutation<WIDTH>, const WIDTH: usize> {
-    trace: Arc<RwLock<Vec<([P::U; WIDTH], [P::U; WIDTH])>>>,
+    trace: Arc<RwLock<Vec<QueryAnswerPair<P::U, WIDTH>>>>,
     permutation: P,
 }
 
@@ -119,7 +121,7 @@ impl<P: Permutation<WIDTH>, const WIDTH: usize> PermutationWitnessBuilder<P, WID
     }
 
     #[must_use]
-    pub fn trace(&self) -> impl AsRef<[([P::U; WIDTH], [P::U; WIDTH])]> {
+    pub fn trace(&self) -> impl AsRef<[QueryAnswerPair<P::U, WIDTH>]> {
         self.trace.read().clone()
     }
 }

spongefish/tests/derive_generics.rs

@@ -27,6 +27,7 @@ fn codec_derive_handles_generic_types() {
     assert_eq!(roundtrip.value, tagged.value);
     assert!(buf.is_empty());
 
+    #[allow(clippy::items_after_statements)]
     fn assert_codec<T: Codec>(_: &T) {}
     assert_codec(&tagged);
 }

spongefish/tests/test_spec.rs

@@ -128,7 +128,7 @@ fn test_all_duplex_sponge_vectors() {
         .filter(|(_, test_vector)| test_vector.hash_function == "SHAKE128")
         .map(|(name, test_vector)| {
             Trial::test(
-                format!("tests::spec::test_duplex_sponge::{}", name),
+                format!("tests::spec::test_duplex_sponge::{name}"),
                 move || run_test_vector(&name, &test_vector),
             )
         })