Skip to content

Commit 9ff2c6b

Browse files
jayfoadgithub-actions[bot]
authored andcommitted
Automerge: [AMDGPU] Simplify some isVALU calls. NFC. (#210057)
2 parents ced3834 + 1cb7e83 commit 9ff2c6b

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

llvm/lib/Target/AMDGPU/AMDGPUHWEvents.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ LLVM_DUMP_METHOD void HWEvents::dump() const { dbgs() << *this << "\n"; }
2222

2323
static HWEvents getExpertSchedulingEventType(const MachineInstr &Inst,
2424
const SIInstrInfo &TII) {
25-
if (TII.isVALU(Inst, /*AllowLDSDMA=*/true) && !SIInstrInfo::isLDSDMA(Inst)) {
25+
if (TII.isVALU(Inst, /*AllowLDSDMA=*/false)) {
2626
// Core/Side-, DP-, XDL- and TRANS-MACC VALU instructions complete
2727
// out-of-order with respect to each other, so each of these classes
2828
// has its own event.

llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2498,7 +2498,7 @@ bool SIInsertWaitcnts::generateWaitcntInstBefore(
24982498
// waits on VA_VDST if the instruction it would precede is not a VALU
24992499
// instruction, since hardware handles VALU->VGPR->VALU hazards in
25002500
// expert scheduling mode.
2501-
if (TII.isVALU(MI, /*AllowLDSDMA=*/true) && !SIInstrInfo::isLDSDMA(MI))
2501+
if (TII.isVALU(MI, /*AllowLDSDMA=*/false))
25022502
Wait.set(AMDGPU::VA_VDST, ~0u);
25032503

25042504
// Since the translation for VMEM addresses occur in-order, we can apply the

0 commit comments

Comments
 (0)