feat: Copy the firmware to /lib/firmware at start not create

Signed-off-by: Yejin Seo <yejseo01@arm.com>

Author: yejseo01

internal/oci/annotations.go

@@ -9,8 +9,8 @@ import (
 const (
 	SpecName = "remoteproc.name"
 
-	StateResolvedPath = "remoteproc.resolved-path"
-	StateFirmware     = "remoteproc.firmware"
+	StateDriverPath = "remoteproc.resolved-path"
+	StateFirmwarePath     = "remoteproc.firmware"
 )
 
 func validateSpecAnnotations(spec *specs.Spec) error {
@@ -22,7 +22,7 @@ func validateSpecAnnotations(spec *specs.Spec) error {
 }
 
 func validateStateAnnotations(state *specs.State) error {
-	return validateAnnotationsExist(state.Annotations, StateResolvedPath, StateFirmware)
+	return validateAnnotationsExist(state.Annotations, StateDriverPath, StateFirmwarePath)
 }
 
 func validateAnnotationsExist(annotations map[string]string, keys ...string) error {

internal/remoteproc/remoteproc.go

@@ -110,10 +110,12 @@ func StoreFirmware(sourcePath string) (string, error) {
 	return targetFileName, nil
 }
 
+// RemoveFirmware deletes a firmware file from /lib/firmware.
 func RemoveFirmware(firmwareFileName string) error {
 	return os.Remove(filepath.Join(rprocFirmwareStorePath, firmwareFileName))
 }
 
+// SetFirmware writes the firmware file name to the remoteproc firmware sysfs entry.
 func SetFirmware(devicePath string, firmwareFileName string) error {
 	state, err := GetState(devicePath)
 	if err != nil {

internal/runtime/create.go

@@ -35,21 +35,17 @@ func Create(containerID string, bundlePath string, pidFile string) error {
 	if err := validateFirmwareExists(firmwarePath); err != nil {
 		return err
 	}
-	storedFirmwareName, err := remoteproc.StoreFirmware(firmwarePath)
 	if err != nil {
 		return fmt.Errorf("failed to store firmware file %s: %w", firmwarePath, err)
 	}
-	needCleanup := true
-	defer func() {
-		if needCleanup {
-			_ = remoteproc.RemoveFirmware(storedFirmwareName)
-		}
-	}()
 
 	pid, err := proxy.NewProcess(devicePath)
 	if err != nil {
 		return fmt.Errorf("failed to start proxy process: %w", err)
 	}
+
+	needCleanup := true
+
 	defer func() {
 		if needCleanup {
 			_ = proxy.StopFirmware(pid)
@@ -58,8 +54,8 @@ func Create(containerID string, bundlePath string, pidFile string) error {
 
 	state := oci.NewState(containerID, bundlePath)
 	state.Pid = pid
-	state.Annotations[oci.StateResolvedPath] = devicePath
-	state.Annotations[oci.StateFirmware] = storedFirmwareName
+	state.Annotations[oci.StateDriverPath] = devicePath
+	state.Annotations[oci.StateFirmwarePath] = firmwarePath
 	if err := oci.WriteState(state); err != nil {
 		return err
 	}

internal/runtime/delete.go

@@ -22,14 +22,14 @@ func Delete(logger *slog.Logger, containerID string, force bool) error {
 func delete(containerID string) error {
 	state, err := oci.ReadState(containerID)
 	if err != nil {
-		return fmt.Errorf("failed to read state: %w", err)
+		return fmt.Errorf("failed to read state 1: %w", err)
 	}
 
 	if state.Status == specs.StateRunning {
 		return fmt.Errorf("cannot delete running container %s", containerID)
 	}
 
-	_ = remoteproc.RemoveFirmware(state.Annotations[oci.StateFirmware])
+	_ = remoteproc.RemoveFirmware(state.Annotations[oci.StateFirmwarePath])
 
 	if err := oci.RemoveState(containerID); err != nil {
 		return fmt.Errorf("failed to remove state: %w", err)
@@ -41,7 +41,7 @@ func delete(containerID string) error {
 func forceDelete(logger *slog.Logger, containerID string) {
 	state, err := oci.ReadState(containerID)
 	if err != nil {
-		logger.Error("failed to read state", "error", err)
+		logger.Error("failed to read state 2", "error", err)
 		return
 	}
 
@@ -51,7 +51,7 @@ func forceDelete(logger *slog.Logger, containerID string) {
 		}
 	}
 
-	if err := remoteproc.RemoveFirmware(state.Annotations[oci.StateFirmware]); err != nil {
+	if err := remoteproc.RemoveFirmware(state.Annotations[oci.StateFirmwarePath]); err != nil {
 		logger.Error("failed to remove firmware", "error", err)
 	}
 

internal/runtime/kill.go

@@ -12,7 +12,7 @@ import (
 func Kill(containerID string, signal syscall.Signal) error {
 	state, err := oci.ReadState(containerID)
 	if err != nil {
-		return fmt.Errorf("failed to read state: %w", err)
+		return fmt.Errorf("failed to read state 3: %w", err)
 	}
 
 	if state.Pid > 0 {

internal/runtime/start.go

@@ -12,12 +12,28 @@ import (
 func Start(containerID string) error {
 	state, err := oci.ReadState(containerID)
 	if err != nil {
-		return fmt.Errorf("failed to read state: %w", err)
+		return fmt.Errorf("failed to read state 4: %w", err)
 	}
+	firmwarePath := state.Annotations[oci.StateFirmwarePath]
+	if firmwarePath == "" {
+		return fmt.Errorf("firmware path annotation missing")
+	}
+
+	storedFirmwareName, err := remoteproc.StoreFirmware(firmwarePath)
+	if err != nil {
+		return fmt.Errorf("failed to store firmware file %s: %w", firmwarePath, err)
+	}
+	needsCleanup := true
+
+	defer func() {
+		if needsCleanup {
+			_ = remoteproc.RemoveFirmware(storedFirmwareName)
+		}
+	}()
 
 	if err := remoteproc.SetFirmware(
-		state.Annotations[oci.StateResolvedPath],
-		state.Annotations[oci.StateFirmware],
+		state.Annotations[oci.StateDriverPath],
+		storedFirmwareName,
 	); err != nil {
 		return fmt.Errorf("failed to set firmware: %w", err)
 	}
@@ -30,6 +46,6 @@ func Start(containerID string) error {
 	if err := oci.WriteState(state); err != nil {
 		return fmt.Errorf("failed to write state: %w", err)
 	}
-
+	needsCleanup = false
 	return nil
 }

internal/runtime/state.go

@@ -10,7 +10,7 @@ import (
 func State(containerID string) (*specs.State, error) {
 	state, err := oci.ReadState(containerID)
 	if err != nil {
-		return nil, fmt.Errorf("failed to read state: %w", err)
+		return nil, fmt.Errorf("failed to read state 5: %w", err)
 	}
 	return state, nil
 }