fix:Simplify FirmwareExists() function

Signed-off-by: Yejin Seo <yejseo01@arm.com>

Author: yejseo01

pkg/simulator/filesystem.go

@@ -4,7 +4,6 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
-	"strings"
 )
 
 type FileSystemManager struct {
@@ -19,7 +18,7 @@ func NewFileSystemManager(rootDir string, index uint) *FileSystemManager {
 	return &FileSystemManager{
 		instanceDir:         filepath.Join(rootDir, "sys", "class", "remoteproc", instanceName),
 		firmwareDirPathFile: filepath.Join(rootDir, "sys", "module", "firmware_class", "parameters", "path"),
-		firmwareDir:         filepath.Join(rootDir, "userhome", "firmware"),
+		firmwareDir:         filepath.Join(rootDir, "firmware"),
 		createdDirs:         []string{},
 	}
 }
@@ -38,10 +37,8 @@ func (fs *FileSystemManager) BootstrapDirectories() error {
 		fs.Cleanup()
 		return fmt.Errorf("failed to create firmware path directory: %w", err)
 	}
-	if createdFirmwareDirPathFileFolder != "" {
-		fs.createdDirs = append(fs.createdDirs, createdFirmwareDirPathFileFolder)
-	}
-	// Write Firmware path
+	fs.createdDirs = append(fs.createdDirs, createdFirmwareDirPathFileFolder)
+
 	if err := os.WriteFile(fs.firmwareDirPathFile, []byte(fs.firmwareDir), 0644); err != nil {
 		fs.Cleanup()
 		return fmt.Errorf("failed to write firmware path file: %w", err)
@@ -52,9 +49,7 @@ func (fs *FileSystemManager) BootstrapDirectories() error {
 		fs.Cleanup()
 		return fmt.Errorf("failed to create firmware directory: %w", err)
 	}
-	if createdFirmwareDir != "" {
-		fs.createdDirs = append(fs.createdDirs, createdFirmwareDir)
-	}
+	fs.createdDirs = append(fs.createdDirs, createdFirmwareDir)
 
 	return nil
 }
@@ -69,19 +64,8 @@ func (fs *FileSystemManager) WriteInstanceFile(filename, content string) error {
 }
 
 func (fs *FileSystemManager) FirmwareExists(firmwareName string) bool {
-	firmwareDir, err := os.ReadFile(fs.firmwareDirPathFile) // simulate reading the firmware path
-	if err != nil {
-		fmt.Printf("failed to read firmware dir path: %v\n", err)
-		return false
-	}
-	firmwareDirStr := strings.TrimSpace(string(firmwareDir))
-	if firmwareDirStr != fs.firmwareDir {
-		fmt.Printf("firmware path mismatch: expected %s from /sys/module/firmware_class/parameters/path, got %s\n", fs.firmwareDir, firmwareDirStr)
-		return false
-	}
-
 	path := filepath.Join(fs.firmwareDir, firmwareName)
-	_, err = os.Stat(path)
+	_, err := os.Stat(path)
 	return !os.IsNotExist(err)
 }