standardizing mockServer responses and reporting back failure reasons

Signed-off-by: David Slear <david_slear@yahoo.com>

Author: dslear

internal/lookoutui/src/pages/jobs/components/PreemptDialog.test.tsx

@@ -136,7 +136,7 @@ describe("PreemptDialog", () => {
     mockServer.setPostJobsResponse([jobs[0]])
     const { getByRole, findByText } = renderComponent()
 
-    mockServer.setPreemptJobsResponse()
+    mockServer.setPreemptJobsResponse([jobs[0].jobId], [])
 
     await enterPreemptReason("Reason for preemption")
 
@@ -170,7 +170,7 @@ describe("PreemptDialog", () => {
     mockServer.setPostJobsResponse([jobs[0]])
     const { getByRole, findByText, findByRole } = renderComponent()
 
-    mockServer.setPreemptJobsResponse(500, "Internal Server Error")
+    mockServer.setPreemptJobsResponse([], [{ jobId: jobs[0].jobId, errorReason: "Internal Server Error" }])
 
     await enterPreemptReason("Reason for preemption")
 

internal/lookoutui/src/pages/jobs/components/PreemptDialog.tsx

@@ -26,6 +26,8 @@ import { usePreemptJobs } from "../../../services/lookout/usePreemptJobs"
 import dialogStyles from "./DialogStyles.module.css"
 import { JobStatusTable } from "./JobStatusTable"
 
+const MAX_JOB_IDS_TO_DISPLAY = 4
+
 interface PreemptDialogProps {
   onClose: () => void
   selectedItemFilters: JobFiltersWithExcludes[]
@@ -73,13 +75,12 @@ export const PreemptDialog = ({ onClose, selectedItemFilters }: PreemptDialogPro
 
       if (response.failedJobIds.length === 0) {
         const ids = response.successfulJobIds
-        const MAX_DISPLAY = 4
-        if (ids.length <= MAX_DISPLAY) {
+        if (ids.length <= MAX_JOB_IDS_TO_DISPLAY) {
           openSnackbar(`Successfully requested preemption for: ${ids.join(", ")}`, "success")
         } else {
-          const displayed = ids.slice(0, MAX_DISPLAY).join(", ")
+          const displayed = ids.slice(0, MAX_JOB_IDS_TO_DISPLAY).join(", ")
           openSnackbar(
-            `Successfully requested preemption for ${ids.length} jobs: ${displayed}, and ${ids.length - MAX_DISPLAY} more`,
+            `Successfully requested preemption for ${ids.length} jobs: ${displayed}, and ${ids.length - MAX_JOB_IDS_TO_DISPLAY} more`,
             "success",
           )
         }
@@ -89,6 +90,9 @@ export const PreemptDialog = ({ onClose, selectedItemFilters }: PreemptDialogPro
 
       const newResponseStatus = { ...jobIdsToPreemptResponses }
 
+      response.successfulJobIds.forEach((jobId) => {newResponseStatus[jobId] = "Success"})
+      response.failedJobIds.forEach(({ jobId, errorReason }) => {newResponseStatus[jobId] = errorReason})
+
       setJobIdsToPreemptResponses(newResponseStatus)
       setHasAttemptedPreempt(true)
     } finally {

internal/lookoutui/src/services/lookout/mocks/mockServer.ts

@@ -150,26 +150,19 @@ export class MockServer {
     )
   }
 
-  setPreemptJobsResponse(status_code: number = 200, status_text: string = "") {
+  setPreemptJobsResponse(successfulJobIds: JobId[], failedJobIds: { jobId: JobId; errorReason: string }[] = []) {
     this.server.use(
       http.post(PREEMPT_JOBS_ENDPOINT, async (req) => {
-        if (status_code !== 200) {
-          return HttpResponse.json(
-            {
-              code: 500,
-              message: "Internal server error",
-              details: [],
-            },
-            { status: status_code, statusText: status_text },
-          )
-        }
-        const reqJson = (await req.request.json()) as { jobIds?: string[] }
-        const jobIds = reqJson.jobIds ?? []
-        const preemptionResults: Record<string, string> = {}
-        for (const jobId of jobIds) {
+        const preemptionResults: Record<JobId, string> = {}
+        for (const jobId of successfulJobIds) {
           preemptionResults[jobId] = ""
         }
-        return HttpResponse.json({ preemptionResults })
+        for (const { jobId, errorReason } of failedJobIds) {
+          preemptionResults[jobId] = errorReason
+        }
+        return HttpResponse.json({ 
+          preemptionResults, 
+        })
       }),
     )
   }