chore: upgrade go version to v1.26.0

Signed-off-by: Dejan Zele Pejchev <pejcev.dejan@gmail.com>

Author: dejanzele

.github/actions/setup-go-cache/action.yml

@@ -5,9 +5,9 @@ inputs:
     description: "Prefix for the cache key"
     required: true
   go-version:
-    description: "Version of Go. Default 1.25"
+    description: "Version of Go. Default 1.26"
     required: false
-    default: "1.25"
+    default: "1.26"
   cache-tools:
     description: "True/false flag to cache tools"
     required: false

.github/workflows/lint.yml

@@ -61,7 +61,7 @@ jobs:
       - name: Lint using golangci-lint
         uses: golangci/golangci-lint-action@v9
         with:
-          version: v2.5.0
+          version: v2.9.0
           only-new-issues: true
           skip-cache: true
           args: --timeout=10m --issues-exit-code=1 ./...

.goreleaser.yml

@@ -19,7 +19,7 @@ env:
   # To use a builder other than "default", set this variable.
   # Necessary for, e.g., GitHub actions cache integration.
   - DOCKER_BUILDX_BUILDER={{ if index .Env "DOCKER_BUILDX_BUILDER"  }}{{ .Env.DOCKER_BUILDX_BUILDER }}{{ else }}default{{ end }}
-  - GOVERSION={{ if index .Env "GOVERSION"  }}{{ .Env.GOVERSION }}{{ else }}go1.25{{ end }}
+  - GOVERSION={{ if index .Env "GOVERSION"  }}{{ .Env.GOVERSION }}{{ else }}go1.26{{ end }}
 
 builds:
   - env: [CGO_ENABLED=0]

docs/developer_guide.md

@@ -72,7 +72,7 @@ For more information about Armada's design, see the following pages:
 
 Before you can start using Armada, you first need to install the following items:
 
-- [`Go`](https://go.dev/doc/install) (version 1.25 or later)
+- [`Go`](https://go.dev/doc/install) (version 1.26 or later)
 - `gcc` (for Windows, [see `tdm-gcc`](https://jmeubank.github.io/tdm-gcc/))
 - [`mage`](https://magefile.org/)
 - [`docker`](https://docs.docker.com/get-docker/)

go.mod

@@ -1,6 +1,6 @@
 module github.com/armadaproject/armada
 
-go 1.25.5
+go 1.26.0
 
 require (
 	github.com/apache/pulsar-client-go v0.18.0

internal/server/submit/validation/submit_request.go

@@ -253,7 +253,7 @@ func validateResources(j *api.JobSubmitRequestItem, config configuration.Submiss
 		maxOversubscriptionByResource = map[string]float64{}
 	}
 	for _, container := range armadaslices.Concatenate(spec.Containers, spec.InitContainers) {
-		if len(container.Resources.Requests) == 0 && len(container.Resources.Requests) == 0 {
+		if len(container.Resources.Requests) == 0 && len(container.Resources.Limits) == 0 {
 			return fmt.Errorf("container %v has no resources specified", container.Name)
 		}
 

magefiles/cmd.go

@@ -122,7 +122,7 @@ func go_CMD() ([]string, error) {
 		"GARCH=amd64",
 		"-v",
 		fmt.Sprintf("%s:/go", DOCKER_GOPATH_DIR),
-		"golang:1.25-bookworm",
+		"golang:1.26-bookworm",
 	}, nil
 }
 

magefiles/go.go

@@ -8,7 +8,7 @@ import (
 	"github.com/pkg/errors"
 )
 
-const GO_VERSION_CONSTRAINT = ">= 1.25.0"
+const GO_VERSION_CONSTRAINT = ">= 1.26.0"
 
 func goBinary() string {
 	return binaryWithExt("go")

tools.yaml

@@ -13,4 +13,4 @@ tools:
 - golang.org/x/tools/cmd/goimports@v0.38.0
 - sigs.k8s.io/kind@v0.25.0
 - github.com/sqlc-dev/sqlc/cmd/sqlc@v1.30.0
-- github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.5.0
+- github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.9.0

website/content/developer-guide.mdx

@@ -9,7 +9,7 @@ This guide helps you set up a development environment for contributing to Armada
 
 Install the following tools before you begin. These are verified requirements from the Armada source code:
 
-- **[Go](https://go.dev/doc/install)** (version 1.25 or later) - Required for building Armada
+- **[Go](https://go.dev/doc/install)** (version 1.26 or later) - Required for building Armada
 - **gcc** (for Windows, see [tdm-gcc](https://jmeubank.github.io/tdm-gcc/)) - Required for CGO compilation
 - **[mage](https://magefile.org/)** - Build tool used throughout the Armada project (similar to Make, written in Go)
 - **[Docker](https://docs.docker.com/get-docker/)** - Container runtime for running dependencies