fix a bunch of more or less significant issues

Author: EvilOlaf

packages/bsp/common/usr/bin/armbian-debug

@@ -78,8 +78,11 @@ Main() {
 				sed -E 's/([0-9]{1,3}\.)([0-9]{1,3}\.)([0-9]{1,3}\.)([0-9]{1,3})/XXX.XXX.\3\4/g' |
 				curl -s --fail --data-binary @- "https://${paste_server}/log"
 
+			# Save PIPESTATUS before any other command
+			pipe_status=("${PIPESTATUS[@]}")
+
 			# Check PIPESTATUS
-			for i in "${PIPESTATUS[@]}"; do
+			for i in "${pipe_status[@]}"; do
 				counter=$((counter + 1))
 				if [[ $i -ne 0 ]]; then
 					echo "Failed (pipe ${counter} returned ${i})."
@@ -93,7 +96,7 @@ Main() {
 		done
 
 		if [ "$upload_success" = true ]; then
-			echo -e "\n${BOLD}Upload successful!${NC} Please post the URL above in the forum.\n"
+			echo -e "\n${BOLD}Upload successful!${NC} Please post the URL at the place where you have been asked for.\n"
 		else
 			echo -e "\n${BOLD}All upload attempts failed. Outputting to stdout instead:${NC}\n"
 			CollectSupportInfo |
@@ -108,7 +111,7 @@ CollectSupportInfo() {
 	[[ -s /var/log/armbian-hardware-monitor.log ]] && cat /var/log/armbian-hardware-monitor.log || zcat /var/log/armbian-hardware-monitor.log.1.gz 2> /dev/null
 	[[ -f /boot/armbianEnv.txt ]] && LOGLEVEL=$(awk -F'=' '/^verbosity/ {print $2}' /boot/armbianEnv.txt)
 	LOGLEVEL=${LOGLEVEL:-1}
-	if [ ${LOGLEVEL} -gt 4 ]; then
+	if [ "$LOGLEVEL" -gt 4 ]; then
 		VERBOSE='-v'
 		which lshw > /dev/null 2>&1 && (
 			echo -e "\n### lshw:"
@@ -129,23 +132,21 @@ CollectSupportInfo() {
 		echo -e "\n### nvme:\n"
 		nvme list 2> /dev/null
 	)
-	[ -z $SUDO_USER ] || echo -e "\n### Group membership of $(groups $SUDO_USER)"
+	[ -z "$SUDO_USER" ] || echo -e "\n### Group membership of $(groups "$SUDO_USER")"
 	echo -en "\n### Userland"
 	[[ -f /etc/armbian-release ]] && echo -en " generated with Armbian Build Framework"
 	echo -en ":\n"
 	echo -e "\n$(grep PRETTY_NAME /etc/os-release)"
 	echo -e "\n### Installed packages:\n\n$(dpkg -l | grep -E "openmediavault|armbian| linux-")"
-	KernelVersion=$(awk -F" " '{print $3}' < /proc/version)
-	case ${KernelVersion} in
-		3.*)
-			[[ -e /boot/script.bin ]] && echo -e "\n### fex settings: $(ls -la /boot/script.bin)\n\n$(bin2fex /boot/script.bin 2> /dev/null)"
-			;;
-	esac
 	echo -e "\n### Loaded modules:\n\n$(lsmod)"
 	[[ -f /var/log/nand-sata-install.log ]] && echo -e "\n### nand-sata-install.log:\n\n$(cat /var/log/nand-sata-install.log)"
 	echo -e "\n### Current sysinfo:\n\n$(command -v iostat >/dev/null 2>&1 && iostat -p ALL | grep -v "^loop")\n\n$(vmstat -w)\n\n$(free -h)\n\n$(zramctl 2> /dev/null)\n\n$(uptime)\n\n$(dmesg | tail -n 250)"
 	echo -e "\n"
-	[[ "$(id -u)" -eq "0" ]] && for sysfsnode in /proc/sys/vm/*; do sysctl $(echo ${sysfsnode} | sed 's|/proc/sys/vm/|vm.|'); done
+	if [[ "$(id -u)" -eq "0" ]]; then
+		for sysfsnode in /proc/sys/vm/*; do
+			sysctl "${sysfsnode/\/proc\/sys\/vm\//vm.}"
+		done
+	fi
 	echo -e "\n### interrupts:\n$(cat /proc/interrupts)"
 	ls /tmp/armbianmonitor_checks_* > /dev/null 2>&1 || return 0
 	for file in /tmp/armbianmonitor_checks_*; do