Skip to content

Commit 666402b

Browse files
nehebigorpecovnik
neheb
authored and
igorpecovnik
committed
mvebu: fix some dmesg warnings for Helios4
Mostly missing regulators. Signed-off-by: Rosen Penev <rosenp@gmail.com>
1 parent aad7b75 commit 666402b

4 files changed

Lines changed: 233 additions & 0 deletions

‎patch/kernel/archive/mvebu-6.18/20-ARM-dts-helios4-add-vcc-supply-to-EEPROM.patch‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
From 880bf48b805ba6a43e5121c4e96804e859c82275 Mon Sep 17 00:00:00 2001
2+
From: Rosen Penev <rosenp@gmail.com>
3+
Date: Sat, 20 Jun 2026 23:13:27 -0700
4+
Subject: [PATCH] ARM: dts: helios4: add vcc-supply to EEPROM
5+
6+
The at24 driver requests a 'vcc' supply for the EEPROM, producing
7+
'supply vcc not found, using dummy regulator' at boot when the
8+
property is missing.
9+
10+
The EEPROM sits on the Helios 4 and is powered by the
11+
same always-on 3.3V rail used by other on-board I2C devices.
12+
Add vcc-supply = <&reg_3p3v> to silence the warning.
13+
14+
Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
15+
Assisted-by: opencode:big-pickle
16+
Signed-off-by: Rosen Penev <rosenp@gmail.com>
17+
---
18+
arch/arm/boot/dts/marvell/armada-388-helios4.dts | 4 ++++
19+
1 file changed, 4 insertions(+)
20+
21+
diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
22+
index 390e98df49c9..05540b8012c2 100644
23+
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
24+
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
25+
@@ -201,6 +201,10 @@ temp_sensor: temp@4c {
26+
reg = <0x4c>;
27+
vcc-supply = <&reg_3p3v>;
28+
};
29+
+
30+
+ eeprom@53 {
31+
+ vcc-supply = <&reg_3p3v>;
32+
+ };
33+
};
34+
35+
i2c@11100 {
36+
--
37+
2.54.0
38+

‎patch/kernel/archive/mvebu-6.18/21-ARM-dts-helios4-add-vcc-supply-to-GPIO-expander.patch‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
From 5328bd6eaf5b994e51680a2f71bec99022a0bedd Mon Sep 17 00:00:00 2001
2+
From: Rosen Penev <rosenp@gmail.com>
3+
Date: Sat, 20 Jun 2026 23:39:00 -0700
4+
Subject: [PATCH] ARM: dts: helios4: add vcc-supply to GPIO expander
5+
6+
The pca953x driver requests a 'vcc' supply, producing:
7+
pca953x 0-0020: supply vcc not found, using dummy regulator
8+
9+
The PCA9655 (PCA9555-compatible) expander is powered by the same
10+
always-on 3.3V rail as the other I2C devices on the bus. Add
11+
vcc-supply = <&reg_3p3v> to silence the warning.
12+
13+
Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
14+
Assisted-by: opencode:big-pickle
15+
Signed-off-by: Rosen Penev <rosenp@gmail.com>
16+
---
17+
arch/arm/boot/dts/marvell/armada-388-helios4.dts | 1 +
18+
1 file changed, 1 insertion(+)
19+
20+
diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
21+
index 05540b8012c2..cf0432a0e71a 100644
22+
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
23+
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
24+
@@ -169,6 +169,7 @@ expander0: gpio-expander@20 {
25+
gpio-controller;
26+
#gpio-cells = <2>;
27+
reg = <0x20>;
28+
+ vcc-supply = <&reg_3p3v>;
29+
pinctrl-names = "default";
30+
pinctrl-0 = <&pca0_pins>;
31+
interrupt-parent = <&gpio0>;
32+
--
33+
2.54.0
34+

‎patch/kernel/archive/mvebu-6.18/22-ARM-dts-helios4-add-SATA-regulator-supplies.patch‎

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
From bdcacaa9278e7050f346061b5114f16b1ee1cc19 Mon Sep 17 00:00:00 2001
2+
From: Rosen Penev <rosenp@gmail.com>
3+
Date: Sat, 20 Jun 2026 23:17:16 -0700
4+
Subject: [PATCH] ARM: dts: helios4: add SATA regulator supplies
5+
6+
The ahci-mvebu driver and libahci_platform request three supplies
7+
on SATA controller and port nodes:
8+
- ahci-supply (controller power)
9+
- phy-supply (PHY power)
10+
- target-supply (disk power per port)
11+
12+
Without them the regulator core prints notices at boot, e.g.:
13+
supply ahci not found, using dummy regulator
14+
supply phy not found, using dummy regulator
15+
supply target not found, using dummy regulator
16+
17+
The SATA controller and PHY inside the Armada 388 SoC are powered
18+
by the 3.3V I/O rail; the four disk bays are powered by the 5V HDD
19+
rail. Wire the existing fixed regulators accordingly.
20+
21+
Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
22+
Assisted-by: opencode:big-pickle
23+
Signed-off-by: Rosen Penev <rosenp@gmail.com>
24+
---
25+
arch/arm/boot/dts/marvell/armada-388-helios4.dts | 8 ++++++++
26+
1 file changed, 8 insertions(+)
27+
28+
diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
29+
index cf0432a0e71a..626a7339a5d0 100644
30+
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
31+
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
32+
@@ -222,13 +222,17 @@ sata@a8000 {
33+
status = "okay";
34+
#address-cells = <1>;
35+
#size-cells = <0>;
36+
+ ahci-supply = <&reg_3p3v>;
37+
+ phy-supply = <&reg_3p3v>;
38+
39+
sata0: sata-port@0 {
40+
reg = <0>;
41+
+ target-supply = <&reg_5p0v_hdd>;
42+
};
43+
44+
sata1: sata-port@1 {
45+
reg = <1>;
46+
+ target-supply = <&reg_5p0v_hdd>;
47+
};
48+
};
49+
50+
@@ -236,13 +240,17 @@ sata@e0000 {
51+
status = "okay";
52+
#address-cells = <1>;
53+
#size-cells = <0>;
54+
+ ahci-supply = <&reg_3p3v>;
55+
+ phy-supply = <&reg_3p3v>;
56+
57+
sata2: sata-port@0 {
58+
reg = <0>;
59+
+ target-supply = <&reg_5p0v_hdd>;
60+
};
61+
62+
sata3: sata-port@1 {
63+
reg = <1>;
64+
+ target-supply = <&reg_5p0v_hdd>;
65+
};
66+
};
67+
68+
--
69+
2.54.0
70+

‎patch/kernel/archive/mvebu-6.18/23-ARM-dts-helios4-wire-LM75-into-a-thermal-zone-with-f.patch‎

Lines changed: 91 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,91 @@
1+
From c8a7d8f4f4e698ecb49452fa19e5e094b1c58018 Mon Sep 17 00:00:00 2001
2+
From: Rosen Penev <rosenp@gmail.com>
3+
Date: Sat, 20 Jun 2026 23:32:55 -0700
4+
Subject: [PATCH] ARM: dts: helios4: wire LM75 into a thermal zone with fan
5+
cooling
6+
7+
The LM75 temperature sensor on i2c0 creates a hwmon interface but was
8+
not referenced by any thermal zone, producing:
9+
hwmon hwmon0: temp1_input not attached to any thermal zone
10+
11+
Assisted-by: opencode:big-pickle
12+
Signed-off-by: Rosen Penev <rosenp@gmail.com>
13+
---
14+
.../boot/dts/marvell/armada-388-helios4.dts | 33 +++++++++++++++++++
15+
1 file changed, 33 insertions(+)
16+
17+
diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
18+
index 626a7339a5d0..6e0452217265 100644
19+
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
20+
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
21+
@@ -8,6 +8,7 @@
22+
*/
23+
24+
/dts-v1/;
25+
+#include <dt-bindings/thermal/thermal.h>
26+
#include "armada-388.dtsi"
27+
#include "armada-38x-solidrun-microsom.dtsi"
28+
29+
@@ -68,6 +69,35 @@ reg_5p0v_usb: regulator-5v-usb {
30+
vin-supply = <&reg_12v>;
31+
};
32+
33+
+ thermal-zones {
34+
+ board-thermal {
35+
+ polling-delay-passive = <2000>;
36+
+ polling-delay = <10000>;
37+
+ thermal-sensors = <&temp_sensor>;
38+
+
39+
+ trips {
40+
+ board_alert: board-alert {
41+
+ temperature = <55000>;
42+
+ hysteresis = <5000>;
43+
+ type = "passive";
44+
+ };
45+
+ board_crit: board-crit {
46+
+ temperature = <85000>;
47+
+ hysteresis = <2000>;
48+
+ type = "critical";
49+
+ };
50+
+ };
51+
+
52+
+ cooling-maps {
53+
+ map0 {
54+
+ trip = <&board_alert>;
55+
+ cooling-device = <&fan1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
56+
+ <&fan2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
57+
+ };
58+
+ };
59+
+ };
60+
+ };
61+
+
62+
system-leds {
63+
compatible = "gpio-leds";
64+
pinctrl-names = "default";
65+
@@ -129,6 +159,7 @@ fan1: j10-pwm {
66+
pwms = <&gpio1 9 40000>; /* Target freq:25 kHz */
67+
pinctrl-names = "default";
68+
pinctrl-0 = <&helios_fan1_pins>;
69+
+ #cooling-cells = <2>;
70+
};
71+
72+
fan2: j17-pwm {
73+
@@ -136,6 +167,7 @@ fan2: j17-pwm {
74+
pwms = <&gpio1 23 40000>; /* Target freq:25 kHz */
75+
pinctrl-names = "default";
76+
pinctrl-0 = <&helios_fan2_pins>;
77+
+ #cooling-cells = <2>;
78+
};
79+
80+
usb2_phy: usb2-phy {
81+
@@ -201,6 +233,7 @@ temp_sensor: temp@4c {
82+
compatible = "ti,lm75";
83+
reg = <0x4c>;
84+
vcc-supply = <&reg_3p3v>;
85+
+ #thermal-sensor-cells = <0>;
86+
};
87+
88+
eeprom@53 {
89+
--
90+
2.54.0
91+

0 commit comments

Comments
 (0)