ccache-remote: address CodeRabbit review feedback

- Update outdated Redis security documentation URL
- Add language specifier to DNS record code blocks (MD040)
- Add nginx module requirement comment (http_dav_module)
- Clarify kernel_make_config vs custom_kernel_make_params hook ordering
- Move doc comment to correct function (ccache_format_host_port)
- Clarify loopback URL rewrite safety in Docker hook comment

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: iav

extensions/ccache-remote/README.server-setup.md

@@ -37,7 +37,7 @@
    ```
 
    For advanced security (TLS, ACL, rename-command), see:
-   https://redis.io/docs/management/security/
+   https://redis.io/docs/latest/operate/oss_and_stack/management/security/
 
 3. Publish DNS-SD service — copy `misc/avahi/ccache-redis.service` to `/etc/avahi/services/`:
    ```bash
@@ -113,13 +113,13 @@
 Set `CCACHE_REMOTE_DOMAIN` on the client, then create DNS records.
 
 Redis backend:
-```
+```text
 _ccache._tcp.example.com.  SRV  0 0 6379 ccache.example.com.
 _ccache._tcp.example.com.  TXT  "type=redis"
 ```
 
 HTTP/WebDAV backend:
-```
+```text
 _ccache._tcp.example.com.  SRV  0 0 8088 ccache.example.com.
 _ccache._tcp.example.com.  TXT  "type=http" "path=/ccache/"
 ```

extensions/ccache-remote/ccache-remote.sh

@@ -123,20 +123,20 @@ declare -g -a CCACHE_PASSTHROUGH_VARS=(
 	CCACHE_PCH_EXTSUM
 )
 
-# Discover ccache remote storage via DNS-SD (mDNS/Avahi) or DNS SRV records.
-# Looks for _ccache._tcp services with TXT records: type=http|redis, path=/...
-# Prefers Redis over HTTP when multiple services are found.
-# Sets CCACHE_REMOTE_STORAGE on success, returns 1 if nothing found.
+# Format host:port, wrapping IPv6 addresses in brackets for URL compatibility (RFC 2732)
 function ccache_format_host_port() {
 	local host="$1" port="$2"
-	# Wrap IPv6 addresses in brackets for URL compatibility (RFC 2732)
 	if [[ "${host}" == *:* ]]; then
 		echo "[${host}]:${port}"
 	else
 		echo "${host}:${port}"
 	fi
 }
 
+# Discover ccache remote storage via DNS-SD (mDNS/Avahi) or DNS SRV records.
+# Looks for _ccache._tcp services with TXT records: type=http|redis, path=/...
+# Prefers Redis over HTTP when multiple services are found.
+# Sets CCACHE_REMOTE_STORAGE on success, returns 1 if nothing found.
 function ccache_discover_remote_storage() {
 	# Method 1: DNS-SD browse on local network (requires avahi-browse)
 	if command -v avahi-browse &>/dev/null; then
@@ -342,7 +342,9 @@ function host_pre_docker_launch__setup_remote_ccache() {
 		fi
 	fi
 
-	# Replace loopback addresses with host.docker.internal so the container can reach the host
+	# Replace loopback addresses with host.docker.internal so the container can reach the host.
+	# The regex above matches loopback only in the host position (after ://), so the global
+	# string substitution below is safe — loopback strings in password/path are not matched.
 	if [[ -n "${CCACHE_REMOTE_STORAGE}" ]]; then
 		if [[ "${CCACHE_REMOTE_STORAGE}" =~ ://localhost[:/\|] || \
 			"${CCACHE_REMOTE_STORAGE}" =~ ://127\.0\.0\.1[:/\|] || \

extensions/ccache-remote/misc/nginx/ccache-webdav.conf

@@ -10,6 +10,7 @@
 # Use ONLY in a fully trusted private network.
 # For auth, add auth_basic directives. See nginx WebDAV documentation.
 # Note: ccache does not support HTTPS directly. Use a reverse proxy for TLS.
+# Requires: nginx with http_dav_module (e.g. nginx-full or nginx-extras on Debian/Ubuntu)
 
 server {
     listen 8088;

lib/functions/compilation/kernel-make.sh

@@ -74,6 +74,8 @@ function run_kernel_make_internal() {
 		common_make_params_quoted+=("${llvm_flag}")
 	fi
 
+	# Hook order: kernel_make_config runs first (generic extension config),
+	# then custom_kernel_make_params (user/board overrides can take precedence).
 	call_extension_method "kernel_make_config" <<- 'KERNEL_MAKE_CONFIG'
 		*Hook to customize kernel make environment and parameters*
 		Called right before invoking make for kernel compilation.
@@ -84,7 +86,7 @@ function run_kernel_make_internal() {
 		  - KERNEL_COMPILER, ARCHITECTURE, BRANCH, LINUXFAMILY, toolchain
 	KERNEL_MAKE_CONFIG
 
-	# Allow extensions to modify make parameters and environment variables
+	# Runs after kernel_make_config — allows user/board overrides to take precedence
 	call_extension_method "custom_kernel_make_params" <<- 'CUSTOM_KERNEL_MAKE_PARAMS'
 		*Customize kernel make parameters before compilation*
 		Called after all standard make parameters are set but before invoking make.