Commit cfacf12
committed
fix(ci/shellcheck): pass --shell=bash for per-file lint of board configs
The per-file ShellCheck loops in maintenance-lint-scripts.yml gate
invocation behind `grep -qE '^#!/.*bash' "$file"`, but grep scans every
line — so any board .conf with an embedded `#!/bin/bash` heredoc (e.g.
config/boards/easepi-a2.conf at lines 267/289/496) passes the gate.
The follow-up shellcheck call ran without --shell=bash, so it looked at
line 1 (a `# Rockchip ...` comment), couldn't determine the target
shell, and errored:
In config/boards/easepi-a2.conf line 1:
^-- SC2148 (error): Tips depend on target shell and yours is unknown.
Add a shebang or a 'shell' directive.
Add --shell=bash to both call sites (findings artifact + red-cross
gate). ShellCheck now knows the shell up front, SC2148 no longer fires
on line 1, and the embedded heredocs inside the .conf still get linted
as bash.1 parent 45561f2 commit cfacf12
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | | - | |
| 196 | + | |
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| |||
0 commit comments