Refactor authentication check and update test assertions for consistency

Author: JinethBosilu

src/main/java/com/crimeLink/analyzer/controller/AuthController.java

@@ -84,7 +84,7 @@ public ResponseEntity<?> logout(@AuthenticationPrincipal User user) {
 
     @GetMapping("/me")
     public ResponseEntity<?> getCurrentUser(@AuthenticationPrincipal User user) {
-        if (user == null) {
+        if (user == null || user.getUserId() == null) {
             return ResponseEntity.status(401).body(Map.of("message", "Not authenticated"));
         }
 

src/test/java/com/crimeLink/analyzer/controller/AdminControllerTest.java

@@ -186,8 +186,6 @@ void triggerBackup_shouldReturn200() {
 
     @Test
     void restoreBackup_shouldReturn400_whenFilenameMissing() {
-        when(authentication.getName()).thenReturn("admin@test.com");
-
         ResponseEntity<?> response = controller.restoreBackup(Map.of(), authentication);
 
         assertEquals(400, response.getStatusCode().value());

src/test/java/com/crimeLink/analyzer/controller/DutyRecommendationControllerTest.java

@@ -55,6 +55,6 @@ void getRecommendations_shouldReturn200() throws Exception {
                         .content(objectMapper.writeValueAsString(request)))
                 .andExpect(status().isOk())
                 .andExpect(jsonPath("$[0].officerId").value(1))
-                .andExpect(jsonPath("$[0].officerName").value("Officer A"));
+                .andExpect(jsonPath("$[0].name").value("Officer A"));
     }
 }

src/test/java/com/crimeLink/analyzer/controller/FacialRecognitionControllerTest.java

@@ -78,7 +78,7 @@ void analyzeImage_shouldReturn200_whenValid() throws Exception {
         MockMultipartFile image = new MockMultipartFile("image", "a.jpg", "image/jpeg", "abc".getBytes());
         ObjectNode result = mapper.createObjectNode().put("match", "ok");
 
-        when(facialRecognitionService.analyzeImage(any(), eq(45.0f), eq("user-1"), isNull()))
+        when(facialRecognitionService.analyzeImage(any(), eq(45.0f), eq("unknown"), isNull()))
                 .thenReturn(result);
 
         mockMvc.perform(multipart("/api/facial/analyze").file(image))

src/test/java/com/crimeLink/analyzer/service/MobileDutyServiceTest.java

@@ -47,7 +47,7 @@ void getDutiesByOfficerId_shouldReturnMappedAssignments() {
 
         assertEquals(1, result.size());
         assertEquals("Officer A", result.get(0).getOfficerName());
-        assertEquals("Active".toUpperCase(), result.get(0).getStatus());
+        assertEquals(DutyStatus.Active.name(), result.get(0).getStatus());
     }
 
     @Test