Fix floats appearing in Humanize output for locales that override _format_timeframe (#986)

* Fixed floats in humanize bug

* Simplified changes

* Fixed typo in comments and test cases

Co-authored-by: Jad Chaar <jadchaar@users.noreply.github.com>

Author: anishnya

arrow/locales.py

@@ -147,7 +147,7 @@ def describe(
         :param only_distance: return only distance eg: "11 seconds" without "in" or "ago" keywords
         """
 
-        humanized = self._format_timeframe(timeframe, delta)
+        humanized = self._format_timeframe(timeframe, trunc(delta))
         if not only_distance:
             humanized = self._format_relative(humanized, timeframe, delta)
 
@@ -165,7 +165,8 @@ def describe_multi(
         """
 
         parts = [
-            self._format_timeframe(timeframe, delta) for timeframe, delta in timeframes
+            self._format_timeframe(timeframe, trunc(delta))
+            for timeframe, delta in timeframes
         ]
         if self.and_word:
             parts.insert(-1, self.and_word)
@@ -3318,7 +3319,7 @@ def _format_timeframe(
         else:
             key = timeframe
 
-        return self.timeframes[key].format(trunc(abs(delta)))
+        return self.timeframes[key].format(abs(delta))
 
     def describe_multi(
         self,
@@ -3334,7 +3335,7 @@ def describe_multi(
 
         humanized = ""
         for index, (timeframe, delta) in enumerate(timeframes):
-            last_humanized = self._format_timeframe(timeframe, delta)
+            last_humanized = self._format_timeframe(timeframe, trunc(delta))
             if index == 0:
                 humanized = last_humanized
             elif index == len(timeframes) - 1:  # Must have at least 2 items

tests/test_arrow.py

@@ -2266,6 +2266,25 @@ def test_untranslated_granularity(self, mocker):
         with pytest.raises(ValueError):
             arw.humanize(later, granularity="week")
 
+    # Bulgarian is an example of a language that overrides _format_timeframe
+    # Applicabale to all locales. Note: Contributors need to make sure
+    # that if they override describe or describe_mutli, that delta
+    # is truncated on call
+
+    def test_no_floats(self):
+        arw = arrow.Arrow(2013, 1, 1, 0, 0, 0)
+        later = arw.shift(seconds=55000)
+        humanize_string = arw.humanize(later, locale="bg", granularity="minute")
+        assert humanize_string == "916 минути назад"
+
+    def test_no_floats_multi_gran(self):
+        arw = arrow.Arrow(2013, 1, 1, 0, 0, 0)
+        later = arw.shift(seconds=55000)
+        humanize_string = arw.humanize(
+            later, locale="bg", granularity=["second", "minute"]
+        )
+        assert humanize_string == "916 минути 40 няколко секунди назад"
+
 
 @pytest.mark.usefixtures("time_2013_01_01")
 class TestArrowHumanizeTestsWithLocale: