Skip to content

Commit 68b2e22

Browse files
authored
Use correct log consumer instead of System.out.println (#4)
* Use correct log consumer instead of System.out.println * Remove pointless logging & comments
1 parent 3ccbe32 commit 68b2e22

4 files changed

Lines changed: 4 additions & 15 deletions

File tree

src/main/java/git/artdeell/ArtVK.java

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,10 @@
99

1010
public class ArtVK implements ModInitializer {
1111
public static final String MOD_ID = "artvk";
12-
13-
// This logger is used to write text to the console and the log file.
14-
// It is considered best practice to use your mod id as the logger's name.
15-
// That way, it's clear which mod wrote info, warnings, and errors.
1612
public static final Logger LOGGER = LoggerFactory.getLogger(MOD_ID);
1713

1814
@Override
19-
public void onInitialize() {
20-
// This code runs as soon as Minecraft is in a mod-load-ready state.
21-
// However, some things (like resources) may still be uninitialized.
22-
// Proceed with mild caution.
23-
24-
LOGGER.info("Hello Fabric world!");
25-
}
15+
public void onInitialize() {}
2616

2717
public static Identifier id(String path) {
2818
return Identifier.fromNamespaceAndPath(MOD_ID, path);

src/main/java/git/artdeell/artvk/Vk11CommandEncoder.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
import java.util.List;
1717
import java.util.Optional;
1818
import java.util.OptionalDouble;
19+
20+
import git.artdeell.ArtVK;
1921
import net.fabricmc.api.EnvType;
2022
import net.fabricmc.api.Environment;
2123
import org.jetbrains.annotations.NotNull;
@@ -278,7 +280,7 @@ public void submitRenderPass() {
278280
}
279281

280282
if(poolCapacityLow) {
281-
System.out.println("Descriptor pool capacity is low, submitting out of order");
283+
ArtVK.LOGGER.warn("Descriptor pool capacity is low, submitting out of order");
282284
submit();
283285
}
284286
}

src/main/java/git/artdeell/artvk/Vk11Device.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,6 @@ public Vk11Device(
114114
physicalDevice.deviceType()
115115
);
116116

117-
System.out.println("Max texture size for RGBA: "+deviceInfo.limits().maxTextureSizeForFormat(GpuFormat.RGBA8_UNORM) +" Memory alloc limit: "+vk11Properties.maxMemoryAllocationSize());
118-
119117
IntIntPair graphicsQueueFamily = physicalDevice.graphicsQueueFamilyAndIndex();
120118
assert graphicsQueueFamily != null;
121119
IntIntPair computeQueueFamily = physicalDevice.computeQueueFamilyAndIndex();

src/main/java/git/artdeell/artvk/Vk11Instance.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ protected Vk11Instance(final int debugVerbosity, boolean wantsDebugLabels, final
9090
.pEnabledValidationFeatures(stack.ints(
9191
EXTValidationFeatures.VK_VALIDATION_FEATURE_ENABLE_SYNCHRONIZATION_VALIDATION_EXT
9292
));
93-
System.out.println("validation features: "+features.enabledValidationFeatureCount());
9493
instanceInfo.pNext(features);
9594
}
9695

0 commit comments

Comments
 (0)