Add 'mode' property to filesystem modifications tasks

Author: rayzilt

tasks/automation-tools.yml

@@ -58,6 +58,7 @@
   file:
     dest: "{{ item }}"
     state: "directory"
+    mode: '0755'
   with_items:
     - "/etc/archivematica/automation-tools"
 
@@ -66,6 +67,7 @@
     src: "{{ item }}.j2"
     dest: "/{{ item }}"
     backup: "yes"
+    mode: '644'
   with_items:
     - "etc/archivematica/automation-tools/transfers.conf"
     - "etc/archivematica/automation-tools/transfer-script.sh"

tasks/configure.yml

@@ -5,6 +5,7 @@
     src: "{{ item }}"
     dest: "/etc/rsyslog.d/archivematica.conf"
     backup: "yes"
+    mode: '644'
   with_first_found:
     - files:
         - "templates/{{ inventory_hostname }}/rsyslog.conf.j2"
@@ -44,30 +45,30 @@
   become: yes
   remote_user: "{{ archivematica_src_configure_ss_ssh_user | default('artefactual') }}"
   register: archivematica_src_configure_ss_api_key_temp
-  when: 
+  when:
      - "archivematica_src_configure_dashboard|bool or archivematica_src_configure_ss|bool"
      - "archivematica_src_configure_ss_api_key is undefined"
      - ss_user.stdout != ""
 
 - set_fact: archivematica_src_configure_ss_api_key="{{ archivematica_src_configure_ss_api_key_temp.stdout }}"
-  when: 
+  when:
     - "archivematica_src_configure_dashboard|bool"
     - "archivematica_src_configure_ss_api_key_temp.stdout is defined"
 
 # Create api-key if not defined and SS user was not already configured
 - set_fact: archivematica_src_configure_ss_api_key={{ 999999999999999999999 | random | to_uuid | hash('md5') }}
-  when: 
+  when:
     - "archivematica_src_configure_ss_api_key is undefined"
     - "archivematica_src_configure_ss|bool"
 
 - name: "Create SS superuser"
   django_manage:
-    command: > 
-      create_user 
+    command: >
+      create_user
       --username="{{ archivematica_src_configure_ss_user }}"
-      --password="{{ archivematica_src_configure_ss_password }}" 
+      --password="{{ archivematica_src_configure_ss_password }}"
       --email="{{ archivematica_src_configure_ss_email }}"
-      --api-key="{{ archivematica_src_configure_ss_api_key }}" 
+      --api-key="{{ archivematica_src_configure_ss_api_key }}"
       --superuser
     app_path: "{{ archivematica_src_ss_app }}"
     virtualenv: "{{ archivematica_src_ss_virtualenv }}"
@@ -116,7 +117,7 @@
 - name: "Create Dashboard user and register pipeline on SS"
   django_manage:
     command: >
-      install 
+      install
       --username="{{ archivematica_src_configure_am_user }}"
       --password="{{ archivematica_src_configure_am_password }}"
       --email="{{ archivematica_src_configure_am_email }}"
@@ -187,7 +188,7 @@
     - archivematica_src_configure_dashboard|bool
     - archivematica_src_configure_dashboardsettings is defined
 
-# The rsync user is defined in the rsync_target, as user@host:/path 
+# The rsync user is defined in the rsync_target, as user@host:/path
 - name: "Get rsync user for dip upload"
   set_fact:
     atom_dipupload_ssh_user: "{{ archivematica_src_configure_dashboardsettings['rsync_target'].split('@')[0] }}"

tasks/pipeline-clonecode.yml

@@ -31,4 +31,5 @@
     force: "yes"
     accept_hostkey: "yes"
     recursive: "no"
+    umask: '0022'
   become_flags: "-ES"

tasks/pipeline-environment.yml

@@ -38,6 +38,7 @@
     src: "{{ item.src }}"
     dest: "{{ item.dest }}"
     backup: "yes"
+    mode: '644'
   with_items:
     - src: "etc/sysconfig/archivematica-mcp-server.j2"
       dest: "{{ systemd_environment_path }}/archivematica-mcp-server"
@@ -49,6 +50,7 @@
     src: "{{ item.src }}"
     dest: "{{ item.dest }}"
     backup: "yes"
+    mode: '644'
   with_items:
     - src: "etc/sysconfig/archivematica-mcp-client.j2"
       dest: "{{ systemd_environment_path }}/archivematica-mcp-client"
@@ -100,6 +102,7 @@
     src: "{{ item }}"
     dest: /etc/archivematica/{{ item | basename | regex_replace('\.j2','') }}
     backup: "yes"
+    mode: '644'
   with_first_found:
     - "templates/{{ inventory_hostname }}/dashboard.logging.json.j2"
     - "templates/dashboard.logging.json.j2"
@@ -111,6 +114,7 @@
     src: "{{ item }}"
     dest: /etc/archivematica/{{ item | basename | regex_replace('\.j2','') }}
     backup: "yes"
+    mode: '644'
   with_first_found:
     - "templates/{{ inventory_hostname }}/serverConfig.logging.json.j2"
     - "templates/serverConfig.logging.json.j2"
@@ -122,6 +126,7 @@
     src: "{{ item }}"
     dest: /etc/archivematica/{{ item | basename | regex_replace('\.j2','') }}
     backup: "yes"
+    mode: '644'
   with_first_found:
     - "templates/{{ inventory_hostname }}/clientConfig.logging.json.j2"
     - "templates/clientConfig.logging.json.j2"
@@ -149,6 +154,7 @@
     src: "{{ item.src }}"
     dest: "{{ item.dest }}"
     backup: "yes"
+    mode: '644'
   when:
     - "ansible_service_mgr == 'systemd'"
   with_items:
@@ -171,6 +177,7 @@
   with_items:
     - "archivematica-mcp-server"
     - "archivematica-dashboard"
+    - "fits-nailgun"
   when:
     - ansible_service_mgr == "systemd"
 
@@ -196,4 +203,3 @@
     - ansible_service_mgr == "systemd"
     - archivematica_src_am_mcpclient_instances > 1
   tags: amsrc-mcp-client
-

tasks/pipeline-instcode.yml

@@ -35,6 +35,7 @@
     backup: "yes"
     force: "yes"
     remote_src: "yes"
+    mode: '0644'
 
 #
 # front-end

tasks/pipeline-osconf.yml

@@ -8,6 +8,7 @@
   file:
     dest: "{{ item }}"
     state: "directory"
+    mode: '0755'
   with_items:
     - "/usr/lib/archivematica"
     - "/usr/share/archivematica/archivematicaCommon"

tasks/ss-main.yml

@@ -95,7 +95,7 @@
     virtualenv: "{{ archivematica_src_ss_virtualenv }}"
     virtualenv_command: "{{ archivematica_src_virtualenv }}"
     virtualenv_python: "{{ archivematica_src_virtualenv_python }}"
-    name: 
+    name:
       - "pip=={{ archivematica_src_pip_version }}"
       - "pip-tools=={{ archivematica_src_pip_tools_version }}"
   tags: "amsrc-ss-pydep"
@@ -119,6 +119,7 @@
   file:
     dest: "{{ item }}"
     state: "directory"
+    mode: '0755'
   with_items:
     - "/usr/lib/archivematica"
   tags: "amsrc-ss-osconf"
@@ -137,6 +138,7 @@
   file:
     dest: "{{ item }}"
     state: "directory"
+    mode: '0755'
   with_items:
     - "/etc/archivematica"
   tags: "amsrc-ss-osconf"
@@ -200,6 +202,7 @@
     backup: "yes"
     force: "yes"
     remote_src: "yes"
+    mode: '0644'
   tags: "amsrc-ss-websrv"
 
 

tasks/ss-osconf.yml

@@ -26,6 +26,7 @@
     src: "{{ item }}"
     dest: "/etc/archivematica/storageService.logging.json"
     backup: "yes"
+    mode: '644'
   with_first_found:
     - files:
         - "templates/{{ inventory_hostname }}/storageService.logging.json.j2"