Replace obsolete no-op tracer providers

Author: djjuhasz

internal/batch/service.go

@@ -9,7 +9,7 @@ import (
 
 	"github.com/go-logr/logr"
 	"go.artefactual.dev/tools/ref"
-	"go.opentelemetry.io/otel/trace"
+	"go.opentelemetry.io/otel/trace/noop"
 	temporalapi_enums "go.temporal.io/api/enums/v1"
 	temporalapi_serviceerror "go.temporal.io/api/serviceerror"
 	temporalsdk_client "go.temporal.io/sdk/client"
@@ -142,7 +142,7 @@ func (s *batchImpl) Hints(ctx context.Context) (*goabatch.BatchHintsResult, erro
 func (s *batchImpl) InitProcessingWorkflow(ctx context.Context, req *collection.ProcessingWorkflowRequest) error {
 	req.ValidationConfig = validation.Config{}
 	// req.MetadataConfig = metadata.Config{}
-	tr := trace.NewNoopTracerProvider().Tracer("")
+	tr := noop.NewTracerProvider().Tracer("")
 	err := collection.InitProcessingWorkflow(ctx, tr, s.cc, s.taskQueue, req)
 	if err != nil {
 		s.logger.Error(err, "Error initializing processing workflow.")

internal/collection/goa.go

@@ -13,7 +13,7 @@ import (
 	"strings"
 	"time"
 
-	"go.opentelemetry.io/otel/trace"
+	"go.opentelemetry.io/otel/trace/noop"
 	temporalapi_common "go.temporal.io/api/common/v1"
 	temporalapi_enums "go.temporal.io/api/enums/v1"
 	temporalapi_serviceerror "go.temporal.io/api/serviceerror"
@@ -266,7 +266,7 @@ func (w *goaWrapper) Retry(ctx context.Context, payload *goacollection.RetryPayl
 
 	req.WorkflowID = *goacol.WorkflowID
 	req.CollectionID = goacol.ID
-	tr := trace.NewNoopTracerProvider().Tracer("")
+	tr := noop.NewTracerProvider().Tracer("")
 	if err := InitProcessingWorkflow(ctx, tr, w.cc, w.taskQueue, req); err != nil {
 		return fmt.Errorf("error starting the new workflow instance: %w", err)
 	}

main.go

@@ -26,6 +26,7 @@ import (
 	sdktrace "go.opentelemetry.io/otel/sdk/trace"
 	semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
 	"go.opentelemetry.io/otel/trace"
+	"go.opentelemetry.io/otel/trace/noop"
 	temporalsdk_activity "go.temporal.io/sdk/activity"
 	temporalsdk_client "go.temporal.io/sdk/client"
 	temporalsdk_worker "go.temporal.io/sdk/worker"
@@ -442,7 +443,7 @@ func initTracerProvider(ctx context.Context, logger logr.Logger, cfg TelemetryCo
 	if !cfg.Traces.Enabled || cfg.Traces.Address == "" {
 		logger.V(1).Info("Tracing system is disabled.", "enabled", cfg.Traces.Enabled, "addr", cfg.Traces.Address)
 		shutdown := func(context.Context) error { return nil }
-		return trace.NewNoopTracerProvider(), shutdown, nil
+		return noop.NewTracerProvider(), shutdown, nil
 	}
 
 	conn, err := grpc.DialContext(