Skip to content

Commit 2344d60

Browse files
authored
feat: remove is-builtin-module (#2703)
The node versions we support as per our engines constraint already have a built in function for determining if a module is built in. This removes the dependency and uses the built in function instead.
1 parent addd21d commit 2344d60

File tree

4 files changed

+2
-24
lines changed

4 files changed

+2
-24
lines changed

package-lock.json

-20
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/artillery/lib/platform/aws-ecs/legacy/bom.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ const path = require('path');
22
const fs = require('fs');
33
const A = require('async');
44

5-
const isBuiltinModule = require('is-builtin-module');
5+
const { isBuiltin } = require('node:module');
66
const detective = require('detective-es6');
77
const depTree = require('dependency-tree');
88

@@ -240,7 +240,7 @@ function getCustomJsDependencies(context, next) {
240240
const npmPackages = requires
241241
.filter(
242242
(requireString) =>
243-
!isBuiltinModule(requireString) && !isLocalModule(requireString)
243+
!isBuiltin(requireString) && !isLocalModule(requireString)
244244
)
245245
.map((requireString) => {
246246
return requireString.startsWith('@')

packages/artillery/lib/platform/aws-lambda/dependencies.js

-1
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,6 @@ const createAndUploadLambdaZip = async (
183183
'uninstall',
184184
'dependency-tree',
185185
'detective',
186-
'is-builtin-module',
187186
'try-require',
188187
'walk-sync',
189188
'esbuild-wasm',

packages/artillery/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@
119119
"eventemitter3": "^4.0.4",
120120
"fs-extra": "^10.1.0",
121121
"got": "^11.8.5",
122-
"is-builtin-module": "^2.0.0",
123122
"joi": "^17.6.0",
124123
"js-yaml": "^3.13.1",
125124
"jsonwebtoken": "^9.0.1",

0 commit comments

Comments
 (0)