Skip to content

Commit fb76207

Browse files
committed
refactor: remove test role from filters
1 parent 975ab29 commit fb76207

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

.github/workflows/s3-publish-cf-templates.yml

+4-8
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ env:
4040
GH_OIDC_TEMPLATE: ${{ inputs.canary && 'github-oidc-canary.yml' || 'github-oidc.yml' }}
4141

4242
jobs:
43+
# Publish templates to AWS S3
4344
put-cloudformation-templates:
4445
runs-on: ubuntu-latest
4546

@@ -66,7 +67,8 @@ jobs:
6667
aws s3 cp --acl public-read ./packages/artillery/lib/platform/aws/iam-cf-templates/aws-iam-fargate-cf-template.yml s3://artilleryio-cf-templates/${{ env.CF_FARGATE_TEMPLATE }}
6768
aws s3 cp --acl public-read ./packages/artillery/lib/platform/aws/iam-cf-templates/aws-iam-lambda-cf-template.yml s3://artilleryio-cf-templates/${{ env.CF_LAMBDA_TEMPLATE }}
6869
aws s3 cp --acl public-read ./packages/artillery/lib/platform/aws/iam-cf-templates/github-oidc.yml s3://artilleryio-cf-templates/${{ env.GH_OIDC_TEMPLATE }}
69-
70+
71+
# This job is used to test that the IAM role created from the `github-oidc.yml` CF template has the correct permissions to be able to run Artillery tests on Lambda and Fargate and that the OIDC is set correctly.
7072
set-up-and-run-artillery-test-on-aws:
7173
runs-on: ubuntu-latest
7274

@@ -97,7 +99,7 @@ jobs:
9799
role-to-assume: arn:aws:iam::${{ secrets.AWS_ACCOUNT_ID_FRESH_SETUP_TESTS }}:role/ResetAccountForRunningTests
98100
role-session-name: OIDCSession
99101
mask-aws-account-id: true
100-
102+
101103
- name: Install aws-nuke
102104
run: |
103105
curl -sL https://github.com/rebuy-de/aws-nuke/releases/download/v2.25.0/aws-nuke-v2.25.0-linux-amd64.tar.gz | tar -xz
@@ -154,9 +156,6 @@ jobs:
154156
- property: Name
155157
type: "glob"
156158
value: "AWS*"
157-
- property: Name
158-
type: "glob"
159-
value: "nidhi*"
160159
- property: Name
161160
type: "glob"
162161
value: "Organization*"
@@ -167,9 +166,6 @@ jobs:
167166
- property: RoleName
168167
type: "glob"
169168
value: "AWS*"
170-
- property: RoleName
171-
type: "glob"
172-
value: "nidhi*"
173169
- property: RoleName
174170
value: "ResetAccountForRunningTests"
175171
- property: RoleName

0 commit comments

Comments
 (0)