refactor(checkout): use lenient yup schema for saved address validation

Create savedAddressValidationSchema that validates core address fields
without strict phone validation, since saved addresses may have incomplete
phone data (e.g., missing region code). This is more maintainable than
manual boolean checks while being appropriately lenient for saved addresses.

The strict deliveryAddressValidationSchema is still used for form submission
to ensure complete and valid data before checkout.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: erikdstock

src/Apps/Order2/Routes/Checkout/Components/FulfillmentDetailsStep/__tests__/utils.jest.ts

@@ -129,9 +129,9 @@ describe("FulfillmentDetailsStep utils", () => {
             region: "NY",
             postalCode: "10001",
             country: "US",
-            phoneNumber: "1234567890",
-            phoneNumberCountryCode: "US",
-            phoneNumberParsed: { display: "+1 1234567890" },
+            phoneNumber: "5551234567",
+            phoneNumberCountryCode: "+1",
+            phoneNumberParsed: { display: "+1 5551234567" },
             isDefault: false,
           },
         },
@@ -145,9 +145,9 @@ describe("FulfillmentDetailsStep utils", () => {
             region: "ON",
             postalCode: "M5V 3A8",
             country: "CA",
-            phoneNumber: "9876543210",
-            phoneNumberCountryCode: "CA",
-            phoneNumberParsed: { display: "+1 9876543210" },
+            phoneNumber: "4165551234",
+            phoneNumberCountryCode: "+1",
+            phoneNumberParsed: { display: "+1 4165551234" },
             isDefault: true,
           },
         },
@@ -162,14 +162,14 @@ describe("FulfillmentDetailsStep utils", () => {
       )
 
       expect(result).toHaveLength(2)
-      // After sorting: usable addresses come first (non-shippable default comes after usable)
+      // After sorting: shippable addresses come first, then non-shippable
       expect(result[0]).toMatchObject({
         internalID: "address1",
         isShippable: true, // US is in available countries
-        isValid: true, // All required fields present
+        isValid: true, // Lenient validation passes
         isDefault: false,
-        phoneNumber: "1234567890",
-        phoneNumberCountryCode: "US",
+        phoneNumber: "5551234567",
+        phoneNumberCountryCode: "+1",
         address: {
           name: "John Doe",
           country: "US",
@@ -179,10 +179,10 @@ describe("FulfillmentDetailsStep utils", () => {
       expect(result[1]).toMatchObject({
         internalID: "address2",
         isShippable: false, // CA is not in available countries
-        isValid: true, // All required fields present
+        isValid: true, // Lenient validation passes
         isDefault: true,
-        phoneNumber: "9876543210",
-        phoneNumberCountryCode: "CA",
+        phoneNumber: "4165551234",
+        phoneNumberCountryCode: "+1",
         address: {
           name: "Jane Smith",
           country: "CA",

src/Apps/Order2/Routes/Checkout/Components/FulfillmentDetailsStep/utils.ts

@@ -14,7 +14,9 @@ type MeAddresses = ExtractNodeType<
 type GravityAddress = ReturnType<typeof extractNodes<MeAddresses>>[number]
 
 export type ProcessedUserAddress = FormikContextWithAddress & {
+  /** valid shipping country for this order */
   isShippable: boolean
+  /** pre-validated with our client schema (except phone number) */
   isValid: boolean
   internalID: string
   isDefault: boolean
@@ -43,17 +45,20 @@ export const countryNameFromAlpha2 = (country: string): string => {
   return COUNTRY_CODE_TO_COUNTRY_NAME[country.toUpperCase()] || country
 }
 
+/**
+ * Validates saved address fields with lenient phone validation.
+ * Checks for required address fields and phone number presence,
+ * but does not validate phone number format or region code.
+ */
 export const validateAddressFields = (
   values: FormikContextWithAddress,
 ): boolean => {
-  return (
-    !!values.address.name &&
-    !!values.address.country &&
-    !!values.address.addressLine1 &&
-    !!values.address.city &&
-    !!values.phoneNumber &&
-    !!values.phoneNumberCountryCode
-  )
+  try {
+    savedAddressValidationSchema.validateSync(values)
+    return true
+  } catch {
+    return false
+  }
 }
 
 export const processSavedAddresses = (
@@ -83,6 +88,11 @@ export const processSavedAddresses = (
 
 export const sortAddressesByPriority = (addresses: ProcessedUserAddress[]) => {
   return [...addresses].sort((a, b) => {
+    // Shippable addresses always come before non-shippable
+    if (a.isShippable && !b.isShippable) return -1
+    if (!a.isShippable && b.isShippable) return 1
+
+    // Within same shippability group, sort by validity and default status
     const aUsable = a.isShippable && a.isValid
     const bUsable = b.isShippable && b.isValid
 
@@ -151,6 +161,15 @@ export const findInitialSelectedAddress = (
   return processedAddresses[0]
 }
 
+/**
+ * Schema for pre-validating saved addresses - lenient on phone validation
+ * since saved addresses may have incomplete phone data (e.g., missing region code)
+ */
+export const savedAddressValidationSchema = yup.object().shape({
+  ...addressFormFieldsValidator(), // Just address fields, no phone
+  phoneNumber: yup.string().required(), // Just check it exists, not format
+})
+
 export const deliveryAddressValidationSchema = yup
   .object()
   .shape(addressFormFieldsValidator({ withPhoneNumber: true }))