adding list values to configMap

Author: nishyt

examples/app/templates/daemonset.yaml

@@ -32,7 +32,6 @@ spec:
         - mountPath: /var/lib/docker/containers
           name: varlibdockercontainers
           readOnly: true
-      imagePullSecrets: {{ .Values.imagePullSecrets | default list | toJson }}
       terminationGracePeriodSeconds: 30
       tolerations:
       - effect: NoSchedule

examples/app/templates/deployment.yaml

@@ -81,7 +81,6 @@ spec:
         - containerPort: 8443
           name: https
         resources: {}
-      imagePullSecrets: {{ .Values.imagePullSecrets | default list | toJson }}
       securityContext:
         runAsNonRoot: true
       terminationGracePeriodSeconds: 10

examples/app/templates/my-config-props.yaml

@@ -7,4 +7,5 @@ metadata:
 data:
   my.prop1: {{ .Values.myConfigProps.myProp1 | quote }}
   my.prop2: {{ .Values.myConfigProps.myProp2 | quote }}
-  my.prop3: {{ .Values.myConfigProps.myProp3 | quote }}
+  my.prop3: {{ .Values.myConfigProps.myProp3 | quote }}
+  my.services: {{ toYaml .Values.myConfigProps.myServices | nindent 4 }}

examples/app/templates/my-config.yaml

@@ -15,4 +15,5 @@ data:
       healthProbeBindAddress: {{ .Values.myConfig.myConfigYaml.health.healthProbeBindAddress
         | quote }}
     metrics:
-      bindAddress: {{ .Values.myConfig.myConfigYaml.metrics.bindAddress | quote }}
+      bindAddress: {{ .Values.myConfig.myConfigYaml.metrics.bindAddress | quote }}
+    users: {{ toYaml .Values.myConfig.myConfigYaml.users | nindent 6 }}

examples/app/values.yaml

@@ -9,7 +9,6 @@ fluentdElasticsearch:
       requests:
         cpu: 100m
         memory: 200Mi
-imagePullSecrets: []
 kubernetesClusterDomain: cluster.local
 myConfig:
   dummyconfigmapkey: dummyconfigmapvalue
@@ -23,10 +22,18 @@ myConfig:
       healthProbeBindAddress: :8081
     metrics:
       bindAddress: 127.0.0.1:8080
+    users:
+    - default
+    - guest
+    - temp
 myConfigProps:
   myProp1: "1"
   myProp2: val 1
   myProp3: "true"
+  myServices:
+  - docker
+  - helm
+  - k8s
 mySecretCa:
   caCrt: ""
 mySecretVars:

pkg/processor/configmap/configmap.go

@@ -68,7 +68,7 @@ func (d configMap) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstru
 
 	name := appMeta.TrimName(obj.GetName())
 	var values helmify.Values
-	if field, exists, _ := unstructured.NestedStringMap(obj.Object, "data"); exists {
+	if field, exists, _ := unstructured.NestedMap(obj.Object, "data"); exists {
 		field, values = parseMapData(field, name)
 		data, err = yamlformat.Marshal(map[string]interface{}{"data": field}, 0)
 		if err != nil {
@@ -89,7 +89,7 @@ func (d configMap) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstru
 	}, nil
 }
 
-func parseMapData(data map[string]string, configName string) (map[string]string, helmify.Values) {
+func parseMapData(data map[string]interface{}, configName string) (map[string]interface{}, helmify.Values) {
 	values := helmify.Values{}
 	for key, value := range data {
 		valuesNamePath := []string{configName, key}
@@ -121,9 +121,9 @@ func parseMapData(data map[string]string, configName string) (map[string]string,
 	return data, values
 }
 
-func parseYaml(value string, path []string, values helmify.Values) (string, error) {
+func parseYaml(value interface{}, path []string, values helmify.Values) (string, error) {
 	config := map[string]interface{}{}
-	err := yaml.Unmarshal([]byte(value), &config)
+	err := yaml.Unmarshal([]byte(value.(string)), &config)
 	if err != nil {
 		return "", errors.Wrapf(err, "unable to unmarshal configmap %v", path)
 	}
@@ -135,9 +135,10 @@ func parseYaml(value string, path []string, values helmify.Values) (string, erro
 	return string(confBytes), nil
 }
 
-func parseProperties(properties string, path []string, values helmify.Values) (string, error) {
+// func parseProperties(properties string, path []string, values helmify.Values) (string, error) {
+func parseProperties(properties interface{}, path []string, values helmify.Values) (string, error) {
 	var res strings.Builder
-	for _, line := range strings.Split(strings.TrimSuffix(properties, "\n"), "\n") {
+	for _, line := range strings.Split(strings.TrimSuffix(properties.(string), "\n"), "\n") {
 		prop := strings.Split(line, "=")
 		if len(prop) != 2 {
 			return "", errors.Errorf("wrong property format in %v: %s", path, line)

test_data/sample-app.yaml

@@ -184,6 +184,10 @@ data:
       healthProbeBindAddress: :8081
     metrics:
       bindAddress: 127.0.0.1:8080
+    users:
+      - default
+      - guest
+      - temp
   my_config.properties: |
     health.healthProbeBindAddress=8081
     metrics.bindAddress=127.0.0.1:8080
@@ -197,6 +201,10 @@ data:
   my.prop1: "1"
   my.prop2: "val 1"
   my.prop3: "true"
+  my.services:
+    - docker
+    - helm
+    - k8s
 ---
 apiVersion: apps/v1
 kind: DaemonSet