Skip to content

Commit 75f7ba5

Browse files
committed
remove post process
1 parent 1fcec33 commit 75f7ba5

File tree

14 files changed

+3
-79
lines changed

14 files changed

+3
-79
lines changed

pkg/helmify/context.go

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -47,28 +47,19 @@ func (c *Context) Add(obj *unstructured.Unstructured) {
4747

4848
// CreateHelm creates helm chart from context k8s objects
4949
func (c *Context) CreateHelm(stop <-chan struct{}) error {
50-
values := Values{}
5150
var templates []Template
5251
for _, obj := range c.objects {
53-
if interrupted(stop) {
54-
return nil
55-
}
5652
template, err := c.process(obj)
5753
if err != nil {
5854
return err
5955
}
6056
if template != nil {
6157
templates = append(templates, template)
62-
err = values.Merge(template.Values())
63-
if err != nil {
64-
return err
65-
}
6658
}
67-
}
68-
for _, t := range templates {
69-
t.PostProcess(values)
70-
if interrupted(stop) {
59+
select {
60+
case <-stop:
7161
return nil
62+
default:
7263
}
7364
}
7465
return c.output.Create(c.info, templates)
@@ -89,12 +80,3 @@ func (c *Context) process(obj *unstructured.Unstructured) (Template, error) {
8980
}).Warn("skipped: no suitable processor found")
9081
return nil, nil
9182
}
92-
93-
func interrupted(stop <-chan struct{}) bool {
94-
select {
95-
case <-stop:
96-
return true
97-
default:
98-
return false
99-
}
100-
}

pkg/helmify/model.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ type Template interface {
2222
Values() Values
2323
// Write - writes helm template into given writer
2424
Write(writer io.Writer) error
25-
// PostProcess - template post processing using values generated by other templates
26-
PostProcess(values Values)
2725
}
2826

2927
// Values - represents helm template values.yaml

pkg/processor/configmap/configmap.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,3 @@ func (r *result) Write(writer io.Writer) error {
167167
_, err := writer.Write(r.data)
168168
return err
169169
}
170-
171-
func (r *result) PostProcess(helmify.Values) {
172-
}

pkg/processor/crd/crd.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,3 @@ func (r *result) Write(writer io.Writer) error {
8282
_, err := writer.Write(r.data)
8383
return err
8484
}
85-
86-
func (r *result) PostProcess(helmify.Values) {
87-
}

pkg/processor/deployment/deployment.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,3 @@ func (r *result) Write(writer io.Writer) error {
144144
_, err := writer.Write(r.data)
145145
return err
146146
}
147-
148-
func (r *result) PostProcess(helmify.Values) {
149-
}

pkg/processor/rbac/clusterrole.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -74,16 +74,3 @@ func (r *crResult) Write(writer io.Writer) error {
7474
_, err := writer.Write([]byte(r.data))
7575
return err
7676
}
77-
78-
func (r *crResult) PostProcess(values helmify.Values) {
79-
crds, ok, err := unstructured.NestedMap(values, "crd")
80-
if err != nil || !ok {
81-
return
82-
}
83-
for k, v := range crds {
84-
group := v.(map[string]interface{})["group"].(string)
85-
plural := v.(map[string]interface{})["plural"].(string)
86-
r.data = strings.ReplaceAll(r.data, group, "{{ .Values.crd."+k+".group }}")
87-
r.data = strings.ReplaceAll(r.data, plural, "{{ .Values.crd."+k+".plural }}")
88-
}
89-
}

pkg/processor/rbac/clusterrolebinding.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,3 @@ func (r *crbResult) Write(writer io.Writer) error {
9696
_, err := writer.Write(r.data)
9797
return err
9898
}
99-
100-
func (r *crbResult) PostProcess(helmify.Values) {
101-
}

pkg/processor/rbac/role.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -72,16 +72,3 @@ func (r *rResult) Write(writer io.Writer) error {
7272
_, err := writer.Write([]byte(r.data))
7373
return err
7474
}
75-
76-
func (r *rResult) PostProcess(values helmify.Values) {
77-
crds, ok, err := unstructured.NestedMap(values, "crd")
78-
if err != nil || !ok {
79-
return
80-
}
81-
for k, v := range crds {
82-
group := v.(map[string]interface{})["group"].(string)
83-
plural := v.(map[string]interface{})["plural"].(string)
84-
r.data = strings.ReplaceAll(r.data, group, "{{ .Values.crd."+k+".group }}")
85-
r.data = strings.ReplaceAll(r.data, plural, "{{ .Values.crd."+k+".plural }}")
86-
}
87-
}

pkg/processor/rbac/rolebinding.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,3 @@ func (r *rbResult) Write(writer io.Writer) error {
9595
_, err := writer.Write(r.data)
9696
return err
9797
}
98-
99-
func (r *rbResult) PostProcess(values helmify.Values) {
100-
}

pkg/processor/rbac/serviceaccount.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,3 @@ func (r *saResult) Write(writer io.Writer) error {
6060
_, err := writer.Write(r.data)
6161
return err
6262
}
63-
64-
func (r *saResult) PostProcess(values helmify.Values) {
65-
}

0 commit comments

Comments
 (0)