Add PodDisruptionBudget processor

Author: rsrchboy

examples/app/templates/myapp-pdb.yaml

@@ -0,0 +1,14 @@
+apiVersion: policy/v1
+kind: PodDisruptionBudget
+metadata:
+  name: {{ include "app.fullname" . }}-myapp-pdb
+  labels:
+    app: nginx
+  {{- include "app.labels" . | nindent 4 }}
+spec:
+  minAvailable: {{ .Values.myappPdb.minAvailable }}
+  maxUnavailable: {{ .Values.myappPdb.maxUnavailable }}
+  selector:
+    matchLabels:
+      app: nginx
+    {{- include "app.selectorLabels" . | nindent 6 }}

examples/app/values.yaml

@@ -84,6 +84,8 @@ myapp:
       repository: gcr.io/kubebuilder/kube-rbac-proxy
       tag: v0.8.0
   replicas: 3
+myappPdb:
+  minAvailable: 2
 myappService:
   ports:
   - name: https

pkg/app/app.go

@@ -2,14 +2,16 @@ package app
 
 import (
 	"context"
-	"github.com/arttor/helmify/pkg/file"
-	"github.com/arttor/helmify/pkg/processor/job"
-	"github.com/arttor/helmify/pkg/processor/statefulset"
 	"io"
 	"os"
 	"os/signal"
 	"syscall"
 
+	"github.com/arttor/helmify/pkg/file"
+	"github.com/arttor/helmify/pkg/processor/job"
+	"github.com/arttor/helmify/pkg/processor/poddisruptionbudget"
+	"github.com/arttor/helmify/pkg/processor/statefulset"
+
 	"github.com/sirupsen/logrus"
 
 	"github.com/arttor/helmify/pkg/config"
@@ -64,6 +66,7 @@ func Start(stdin io.Reader, config config.Config) error {
 		webhook.MutatingWebhook(),
 		job.NewCron(),
 		job.NewJob(),
+		poddisruptionbudget.New(),
 	).WithDefaultProcessor(processor.Default())
 	if len(config.Files) != 0 {
 		file.Walk(config.Files, config.FilesRecursively, func(filename string, fileReader io.Reader) {

pkg/processor/poddisruptionbudget/pdb.go

@@ -0,0 +1,109 @@
+package poddisruptionbudget
+
+import (
+	"bytes"
+	"fmt"
+	"io"
+	"strings"
+
+	"github.com/arttor/helmify/pkg/processor"
+
+	"github.com/arttor/helmify/pkg/helmify"
+	yamlformat "github.com/arttor/helmify/pkg/yaml"
+	"github.com/iancoleman/strcase"
+	policyv1 "k8s.io/api/policy/v1"
+	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
+	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/runtime/schema"
+	"sigs.k8s.io/yaml"
+)
+
+const (
+	pdbTempSpec = `
+spec:
+  minAvailable: {{ .Values.%[1]s.minAvailable }}
+  maxUnavailable: {{ .Values.%[1]s.maxUnavailable }}
+  selector:
+%[2]s
+    {{- include "%[3]s.selectorLabels" . | nindent 6 }}`
+)
+
+var pdbGVC = schema.GroupVersionKind{
+	Group:   "policy",
+	Version: "v1",
+	Kind:    "PodDisruptionBudget",
+}
+
+// New creates processor for k8s Service resource.
+func New() helmify.Processor {
+	return &pdb{}
+}
+
+type pdb struct{}
+
+// Process k8s Service object into template. Returns false if not capable of processing given resource type.
+func (r pdb) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
+	if obj.GroupVersionKind() != pdbGVC {
+		return false, nil, nil
+	}
+	pdb := policyv1.PodDisruptionBudget{}
+	err := runtime.DefaultUnstructuredConverter.FromUnstructured(obj.Object, &pdb)
+	if err != nil {
+		return true, nil, fmt.Errorf("%w: unable to cast to pdb", err)
+	}
+	spec := pdb.Spec
+	values := helmify.Values{}
+
+	meta, err := processor.ProcessObjMeta(appMeta, obj)
+	if err != nil {
+		return true, nil, err
+	}
+
+	name := appMeta.TrimName(obj.GetName())
+	shortName := strings.TrimPrefix(name, "controller-manager-")
+	shortNameCamel := strcase.ToLowerCamel(shortName)
+
+	selector, _ := yaml.Marshal(pdb.Spec.Selector)
+	selector = yamlformat.Indent(selector, 4)
+	selector = bytes.TrimRight(selector, "\n ")
+
+	if spec.MaxUnavailable != nil {
+		_, err := values.Add(spec.MaxUnavailable.IntValue(), shortNameCamel, "maxUnavailable")
+		if err != nil {
+			return true, nil, err
+		}
+	}
+
+	if spec.MinAvailable != nil {
+		_, err := values.Add(spec.MinAvailable.IntValue(), shortNameCamel, "minAvailable")
+		if err != nil {
+			return true, nil, err
+		}
+	}
+
+	res := meta + fmt.Sprintf(pdbTempSpec, shortNameCamel, selector, appMeta.ChartName())
+	return true, &result{
+		name:   shortName,
+		data:   res,
+		values: values,
+	}, nil
+}
+
+type result struct {
+	name   string
+	data   string
+	values helmify.Values
+}
+
+func (r *result) Filename() string {
+	return r.name + ".yaml"
+}
+
+func (r *result) Values() helmify.Values {
+	return r.values
+}
+
+func (r *result) Write(writer io.Writer) error {
+	_, err := writer.Write([]byte(r.data))
+	return err
+}

pkg/processor/poddisruptionbudget/pdb_test.go

@@ -0,0 +1,42 @@
+package poddisruptionbudget
+
+import (
+	"os"
+	"testing"
+
+	"github.com/arttor/helmify/pkg/metadata"
+
+	"github.com/arttor/helmify/internal"
+	"github.com/stretchr/testify/assert"
+)
+
+const pdbYaml = `apiVersion: policy/v1
+kind: PodDisruptionBudget
+metadata:
+  labels:
+    control-plane: controller-manager
+  name: my-operator-controller-manager-pdb
+  namespace: my-operator-system
+spec:
+  minAvailable: 2
+  selector:
+    matchLabels:
+      control-plane: controller-manager`
+
+func Test_pdb_Process(t *testing.T) {
+	var testInstance pdb
+
+	t.Run("processed", func(t *testing.T) {
+		obj := internal.GenerateObj(pdbYaml)
+		processed, tt, err := testInstance.Process(&metadata.Service{}, obj)
+		_ = tt.Write(os.Stdout)
+		assert.NoError(t, err)
+		assert.Equal(t, true, processed)
+	})
+	t.Run("skipped", func(t *testing.T) {
+		obj := internal.TestNs
+		processed, _, err := testInstance.Process(&metadata.Service{}, obj)
+		assert.NoError(t, err)
+		assert.Equal(t, false, processed)
+	})
+}

test_data/sample-app.yaml

@@ -334,3 +334,15 @@ spec:
         resources:
           requests:
             storage: 1Gi
+---
+apiVersion: policy/v1
+kind: PodDisruptionBudget
+metadata:
+  labels:
+    app: nginx
+  name: myapp-pdb
+spec:
+  minAvailable: 2
+  selector:
+    matchLabels:
+      app: nginx