Description
InferenceData
objects are central to ArviZ, and even though a common subset of tasks using InferenceData can be done directly with ArviZ plotting and stats functions, any task that deviates from this becomes more and more convoluted and long.
The aim of this issue is to start a discussion about new capabilities to add to InferenceData
and generate a proposal (which will be added to xarray_examples for discussion with xarray team).
I also think there are several groups of functions, if it may help start brainstroming or generating different proposals per group. Ideas on all levels are welcome!
Straightforward extensions to xr.Dataset
methods
.sel
is a good example of this. I think several methods could fit in this category and very roughly follow a similar pattern:
def idata_extension(self, groups, ... , **kwargs):
for group in groups:
if group not in self._groups:
raise Error
# some kind of check to make method as convenient as possible
# an example is sel using only the dimensions present in current group to index
dataset = getattr(self, group)
setattr(self, group, datasel.method(**kwargs)
In addition to groups
we should think about other ArviZ specific args, common in most functions and not passed to xarray. Maybe inplace
and/or copy
?
Also, groups
could accept groups and some metagroups so that one keyword represents several proper groups. We could go as far as adding the metagroups dict in rcParams. One metagroup example could be "posteriors" -> ("posterior", "sample_stats", "log_likelihood", "posterior_predictive")
Some ideas of functions that could fit in this category are:
.isel
stack
andunstack
rename
,rename_dims
andrename_vars
.load
and other dask related methods likechunk
would be interesting after ArviZ starts becoming Dask friendly.
Many dataset methods make sense to extend, so I think we should focus on the ones that solve more issues on our side. For example, if we make an extension to apply_ufunc compatible with inference data or extend the map method, the mean, median, max... are not really necessary, only convenient, whereas other methods may have no alternative.
Commenting the ones you expect to use the most seems like a good start to choose where to begin with.
Specific inference data methods
This category requires a much more detailed and custom implementation. Some examples that would fall here are:
- InferenceData html repr
- InferenceData method to print all dims, coords and variables in all groups at once. Maybe add option to show values? In general no values to make it readable. In jupyter may not have much sense because html could already cover this, but for terminal-like environments it would.
- Extension to
xr.where
to select from one group with a condition on another, ideally similar to pandasquery
function - InferenceData compatible apply_ufunc to apply the same transform to several groups, e.g. shift and rescale all values in
prior_predictive
,posterior_predictive
,predictions
andobserved_data
(could also be an extension tomap
butapply_ufunc
should be more versatile)